Refactoring to catch NoSUchEntoty Exception

Author: Nazar65

AdobeStockImageAdminUi/Controller/Adminhtml/Asset/GetMediaGalleryAsset.php

@@ -13,6 +13,7 @@
 use Magento\Framework\Controller\ResultFactory;
 use Psr\Log\LoggerInterface;
 use Magento\AdobeStockImageAdminUi\Model\Asset\GetMediaGalleryAssetByAdobeId;
+use Magento\Framework\Exception\NoSuchEntityException;
 
 /**
  * Backend controller for retrieving asset information by adobeId
@@ -61,7 +62,6 @@ public function execute()
     {
         $resultJson = $this->resultFactory->create(ResultFactory::TYPE_JSON);
         try {
-
             $params = $this->getRequest()->getParams();
             $adobeId = isset($params['adobe_id']) ? $params['adobe_id'] : null;
 
@@ -78,6 +78,9 @@ public function execute()
 
             $responseCode = self::HTTP_OK;
             $responseContent = $this->getAssetByAdobeId->execute((int) $adobeId);
+        } catch (NoSuchEntityException $execption) {
+            $responseCode = self::HTTP_OK;
+            $responseContent = [];
         } catch (\Exception $exception) {
             $responseCode = self::HTTP_INTERNAL_ERROR;
             $this->logger->critical($exception);

AdobeStockImageAdminUi/Model/Asset/GetMediaGalleryAssetByAdobeId.php

@@ -12,6 +12,7 @@
 use Magento\MediaGalleryApi\Api\GetAssetsByIdsInterface;
 use Magento\MediaGalleryApi\Api\Data\AssetInterface;
 use Magento\Framework\Reflection\DataObjectProcessor;
+use Magento\Framework\Exception\NoSuchEntityException;
 
 /**
  * Return media gallery asset by adobe id
@@ -55,13 +56,19 @@ public function __construct(
      *
      * @param int $adobeId
      * @return array
+     * @throws NoSuchEntityException
      */
     public function execute(int $adobeId): array
     {
         $mediaGalleryAsset = $this->getAssetByAdobeId->execute([$adobeId]);
 
         if (!isset($mediaGalleryAsset[$adobeId])) {
-            return [];
+            throw new NoSuchEntityException(
+                __(
+                    'Media Gallery asset with adobe id %id does not exist.',
+                    ['id' => $adobeId]
+                )
+            );
         }
 
         $mediaGalleryId = $mediaGalleryAsset[$adobeId]->getMediaGalleryId();

AdobeStockImageAdminUi/view/adminhtml/web/js/components/grid/column/image-preview.js

@@ -61,30 +61,12 @@ define([
          */
         initialize: function () {
             this._super().initView();
-            $(window).on('fileDeleted.enhancedMediaGallery', function () {
-                this.reloadAdobeGrid();
-            }.bind(this));
-            $(window).on('folderDeleted.enhancedMediaGallery', function () {
-                this.reloadAdobeGrid();
-            }.bind(this));
+            $(window).on('fileDeleted.enhancedMediaGallery', this.reloadAdobeGrid.bind(this));
+            $(window).on('folderDeleted.enhancedMediaGallery', this.reloadAdobeGrid.bind(this));
 
             return this;
         },
 
-        /**
-         * Update is_downloaded filed for displayed record
-         */
-        updateIsDownloadedField: function () {
-            var record = this.displayedRecord();
-
-            this.actions().getAssetDetails(this.displayedRecord().id).then(function (assetDetails) {
-                if (assetDetails.length === 0) {
-                    record['is_downloaded'] = 0;
-                    this.displayedRecord(record);
-                }
-            }.bind(this));
-        },
-
         /**
          * Initialize child components
          *
@@ -207,7 +189,6 @@ define([
          * Reload Adobe grid after deleting image
          */
         reloadAdobeGrid: function () {
-            this.updateIsDownloadedField();
             this.actions().source().reload({
                 refresh: true
             });