Skip to content

Commit c2479db

Browse files
Review changes
1 parent badbd3d commit c2479db

File tree

2 files changed

+21
-22
lines changed

2 files changed

+21
-22
lines changed

MediaGalleryRenditions/Model/GenerateRenditionImages.php

Lines changed: 20 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -7,52 +7,51 @@
77

88
namespace Magento\MediaGalleryRenditions\Model;
99

10-
use Magento\MediaGallerySynchronizationApi\Api\ImportFileInterface;
11-
use Magento\MediaGallerySynchronization\Model\Filesystem\SplFileInfoFactory;
12-
use Magento\MediaGallerySynchronization\Model\CreateAssetFromFile;
10+
use Magento\Framework\Exception\LocalizedException;
11+
use Magento\MediaGallerySynchronization\Model\GetAssetFromPath;
12+
use Magento\MediaGallerySynchronizationApi\Model\ImportFilesInterface;
1313
use Magento\MediaGalleryRenditionsApi\Api\GenerateRenditionsInterface;
1414

1515
/**
1616
* Generate Rendition Images
1717
*/
18-
class GenerateRenditionImages implements ImportFileInterface
18+
class GenerateRenditionImages implements ImportFilesInterface
1919
{
2020
/**
21-
* @var SplFileInfoFactory
21+
* @var GetAssetFromPath
2222
*/
23-
private $splFileInfoFactory;
24-
25-
/**
26-
* @var CreateAssetFromFile
27-
*/
28-
private $createAssetFromFile;
23+
private $getAssetFromPath;
2924

3025
/**
3126
* @var GenerateRenditionsInterface
3227
*/
3328
private $generateRenditions;
3429

3530
/**
36-
* @param SplFileInfoFactory $splFileInfoFactory
37-
* @param CreateAssetFromFile $createAssetFromFile
31+
* @param GetAssetFromPath $getAssetFromPath
3832
* @param GenerateRenditionsInterface $generateRenditions
3933
*/
4034
public function __construct(
41-
SplFileInfoFactory $splFileInfoFactory,
42-
CreateAssetFromFile $createAssetFromFile,
35+
GetAssetFromPath $getAssetFromPath,
4336
GenerateRenditionsInterface $generateRenditions
4437
) {
45-
$this->splFileInfoFactory = $splFileInfoFactory;
46-
$this->createAssetFromFile = $createAssetFromFile;
38+
$this->getAssetFromPath = $getAssetFromPath;
4739
$this->generateRenditions = $generateRenditions;
4840
}
4941

5042
/**
51-
* @inheritdoc
43+
* Save media files data
44+
*
45+
* @param string[] $paths
46+
* @throws LocalizedException
5247
*/
53-
public function execute(string $path): void
48+
public function execute(array $paths): void
5449
{
55-
$file = $this->splFileInfoFactory->create($path);
56-
$this->generateRenditions->execute([$this->createAssetFromFile->execute($file)]);
50+
$assets = [];
51+
52+
foreach ($paths as $path) {
53+
$assets[] = $this->getAssetFromPath->execute($path);
54+
}
55+
$this->generateRenditions->execute($assets);
5756
}
5857
}

MediaGalleryRenditions/etc/di.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<preference for="Magento\MediaGalleryRenditionsApi\Model\ConfigInterface" type="Magento\MediaGalleryRenditions\Model\Config"/>
1010
<preference for="Magento\MediaGalleryRenditionsApi\Api\GenerateRenditionsInterface" type="Magento\MediaGalleryRenditions\Model\GenerateRenditions"/>
1111
<preference for="Magento\MediaGalleryRenditionsApi\Api\GetRenditionPathInterface" type="Magento\MediaGalleryRenditions\Model\GetRenditionPath"/>
12-
<type name="Magento\MediaGallerySynchronizationApi\Model\ImportFileComposite">
12+
<type name="Magento\MediaGallerySynchronizationApi\Model\ImportFilesComposite">
1313
<arguments>
1414
<argument name="importers" xsi:type="array">
1515
<item name="2" xsi:type="object">Magento\MediaGalleryRenditions\Model\GenerateRenditionImages</item>

0 commit comments

Comments
 (0)