Feedback changes

Author: konarshankar07

MediaGalleryIntegration/Plugin/SaveBaseCategoryImageInformation.php

@@ -99,9 +99,10 @@ public function afterMoveFileFromTmp(ImageUploader $subject, string $imagePath):
             $this->deleteAssetsByPaths->execute([$tmpAssets[0]->getPath()]);
         }
 
-        $this->saveAsset->execute([$this->createAssetFromFile->execute($file)]);
+        $createAsset = $this->createAssetFromFile->execute($file);
+        $this->saveAsset->execute([$createAsset]);
         $this->storage->resizeFile($absolutePath);
-        $this->generateRenditions->execute([$file]);
+        $this->generateRenditions->execute([$createAsset]);
         return $imagePath;
     }
 }

MediaGalleryIntegration/Plugin/SaveImageInformation.php

@@ -110,9 +110,10 @@ public function afterSave(Uploader $subject, array $result): array
         if (!$this->isApplicable($file->getPathName())) {
             return $result;
         }
-        $this->saveAsset->execute([$this->createAssetFromFile->execute($file)]);
+        $createAsset = $this->createAssetFromFile->execute($file);
+        $this->saveAsset->execute([$createAsset]);
         $this->storage->resizeFile($result['path'] . DIRECTORY_SEPARATOR . $result['file']);
-        $this->generateRenditions->execute([$file]);
+        $this->generateRenditions->execute([$createAsset]);
         return $result;
     }
 

MediaGalleryRenditions/Model/GenerateRenditions.php

@@ -7,7 +7,10 @@
 
 namespace Magento\MediaGalleryRenditions\Model;
 
+use Magento\Framework\App\Filesystem\DirectoryList;
+use Magento\Framework\Filesystem;
 use Magento\Framework\Image\AdapterFactory;
+use Magento\MediaGalleryApi\Api\Data\AssetInterface;
 use Magento\MediaGalleryRenditionsApi\Api\GenerateRenditionsInterface;
 use Magento\MediaGalleryRenditionsApi\Api\GetRenditionPathInterface;
 use Magento\MediaGalleryRenditionsApi\Model\ConfigInterface;
@@ -34,39 +37,47 @@ class GenerateRenditions implements GenerateRenditionsInterface
      * @var CreateAssetFromFile
      */
     private $createAssetFromFile;
+    /**
+     * @var Filesystem
+     */
+    private $filesystem;
 
     /**
      * GenerateRenditions constructor.
      * @param AdapterFactory $imageFactory
      * @param GetRenditionPathInterface $getRenditionPath
      * @param CreateAssetFromFile $createAssetFromFile
+     * @param Filesystem $filesystem
      * @param ConfigInterface $config
      */
     public function __construct(
         AdapterFactory $imageFactory,
         GetRenditionPathInterface $getRenditionPath,
         CreateAssetFromFile $createAssetFromFile,
+        Filesystem $filesystem,
         ConfigInterface $config
     ) {
         $this->imageFactory = $imageFactory;
         $this->config = $config;
         $this->getRenditionPath = $getRenditionPath;
         $this->createAssetFromFile = $createAssetFromFile;
+        $this->filesystem = $filesystem;
     }
 
     /**
      * @inheritDoc
      */
-    public function execute(array $files): void
+    public function execute(array $assets): void
     {
-        foreach ($files as $file) {
-            $path = $file->getPath() . DIRECTORY_SEPARATOR . $file->getFileName();
-            $asset = $this->createAssetFromFile->execute($file);
+        /* @var $asset AssetInterface */
+        foreach ($assets as $asset) {
+            $mediaDirectory = $this->filesystem->getDirectoryRead(DirectoryList::MEDIA);
+            $path = $mediaDirectory->getAbsolutePath($asset->getPath());
             if (!$this->isResizeable($asset->getHeight(), $asset->getWidth())) {
                 continue;
             }
             $renditionDirectoryPath = $this->getRenditionPath->execute($asset);
-            $renditionImagePath = $renditionDirectoryPath . DIRECTORY_SEPARATOR . $file->getFileName();
+            $renditionImagePath = $renditionDirectoryPath . $asset->getPath();
             $image = $this->imageFactory->create();
             $image->open($path);
             $image->keepAspectRatio(true);
@@ -82,7 +93,7 @@ public function execute(array $files): void
      * @param int $width
      * @return bool
      */
-    private function isResizeable(int $height, int $width) :bool
+    private function isResizeable(int $height, int $width): bool
     {
         return $width > $this->getResizedWidth() || $height > $this->getResizedHeight();
     }
@@ -92,7 +103,7 @@ private function isResizeable(int $height, int $width) :bool
      *
      * @return int
      */
-    private function getResizedWidth() :int
+    private function getResizedWidth(): int
     {
         return $this->config->getWidth();
     }

MediaGalleryRenditionsApi/Api/GenerateRenditionsInterface.php

@@ -14,8 +14,8 @@ interface GenerateRenditionsInterface
     /**
      * Generate Renditions image
      *
-     * @param array $paths
+     * @param array $assets
      * @throws LocalizedException
      */
-    public function execute(array $paths): void;
+    public function execute(array $assets): void;
 }

MediaGallerySynchronization/Model/SynchronizeFiles.php

@@ -90,15 +90,16 @@ public function __construct(
     public function execute(array $files): void
     {
         $assets = $this->getExistingAssets($files);
-        $this->generateRenditions->execute($files);
         foreach ($files as $file) {
+            $createAsset = $this->createAssetFromFile->execute($file);
             $path = $this->getFilePath($file);
             $time = $this->getFileModificationTime($file);
+            $this->generateRenditions->execute([$createAsset]);
             if (isset($assets[$path]) && $time === $assets[$path]) {
                 continue;
             }
             try {
-                $this->saveAsset->execute([$this->createAssetFromFile->execute($file)]);
+                $this->saveAsset->execute([$createAsset]);
             } catch (\Exception $exception) {
                 $this->log->critical($exception);
                 $failedFiles[] = $file->getFilename();