MC-41838: Simplify paths

Author: jayjoshigl

AdobeStockImage/Model/Storage/Save.php

@@ -38,23 +38,28 @@ class Save
      * @var IsPathExcludedInterface
      */
     private $isPathExcluded;
+
+    /**
+     * @var int|null
+     */
     private $maxFileLength;
 
     /**
      * @param Filesystem $filesystem
      * @param Https $driver
      * @param IsPathExcludedInterface $isPathExcluded
+     * @param int|null $maxFileLength
      */
     public function __construct(
         Filesystem $filesystem,
         Https $driver,
         IsPathExcludedInterface $isPathExcluded,
-        $maxFileLength
+        int $maxFileLength = null
     ) {
         $this->filesystem = $filesystem;
         $this->driver = $driver;
         $this->isPathExcluded = $isPathExcluded;
-        $this->maxFileLength = $maxFileLength;
+        $this->maxFileLength = $maxFileLength ?: 255;
     }
 
     /**
@@ -69,12 +74,8 @@ public function __construct(
      */
     public function execute(string $imageUrl, string $destinationPath, bool $allowOverwrite = false): void
     {
-        $maxFilenameLength = $this->maxFileLength;
-
-        if (strlen($destinationPath) > $maxFilenameLength) {
-            throw new \InputException(
-                __('Destination Path is too long; must be %1 characters or less', $maxFilenameLength)
-            );
+        if (strlen($destinationPath) > $this->maxFileLength) {
+            throw new LocalizedException(__('Destination Path is too long; must be %1 characters or less', $this->maxFileLength));
         }
 
         $mediaDirectory = $this->filesystem->getDirectoryWrite(DirectoryList::MEDIA);