MAGETWO-38838: Create composer management library and reuse it in both updater and setup wizard

- chenge in lib interface

Author: Ivan Gavryshko

Tests/Composer/MagentoComposerApplicationTest.php

@@ -49,28 +49,20 @@ protected function setUp()
         $this->consoleOutput = $this->getMock('Symfony\Component\Console\Output\BufferedOutput', [], [], '', false);
 
         $this->application = new MagentoComposerApplication(
+            'path1',
+            'path2',
             $this->composerApplication,
             $this->inputFactory,
             $this->consoleOutput
         );
     }
 
-    /**
-     * @expectedException \Exception
-     * @expectedExceptionMessage Please call setConfig method to configure composer
-     */
-    function testMissedConfigSet()
-    {
-        $this->application->runComposerCommand([]);
-    }
-
     /**
      * @expectedException \RuntimeException
      * @expectedExceptionMessage Command "update" failed
      */
     function testWrongExitCode()
     {
-        $this->application->setConfig('path1', 'path2');
         $this->composerApplication->expects($this->once())->method('run')->willReturn(1);
 
         $this->application->runComposerCommand(['command'=>'update']);
@@ -80,7 +72,6 @@ function testRunCommand()
     {
         $inputData = ['command' => 'update', MagentoComposerApplication::COMPOSER_WORKING_DIR => '.'];
 
-        $this->application->setConfig('path1', 'path2');
         $this->composerApplication->expects($this->once())->method('resetComposer');
 
         $this->inputFactory->expects($this->once())->method('create')->with($inputData);

src/MagentoComposerApplication.php

@@ -63,11 +63,15 @@ class MagentoComposerApplication
     /**
      * Constructs class
      *
+     * @param string $pathToComposerHome
+     * @param string $pathToComposerJson
      * @param Application $consoleApplication
      * @param ConsoleArrayInputFactory $consoleArrayInputFactory
      * @param BufferedOutput $consoleOutput
      */
     public function __construct(
+        $pathToComposerHome,
+        $pathToComposerJson,
         Application $consoleApplication = null,
         ConsoleArrayInputFactory $consoleArrayInputFactory = null,
         BufferedOutput $consoleOutput = null
@@ -76,56 +80,35 @@ public function __construct(
         $this->consoleArrayInputFactory = $consoleArrayInputFactory ? $consoleArrayInputFactory
             : new ConsoleArrayInputFactory();
         $this->consoleOutput = $consoleOutput ? $consoleOutput : new BufferedOutput();
-    }
 
-    /**
-     * Sets composer environment config
-     *
-     * @param string $pathToComposerHome
-     * @param string $pathToComposerJson
-     */
-    public function setConfig($pathToComposerHome, $pathToComposerJson)
-    {
         $this->composerJson = $pathToComposerJson;
         $this->composerHome = $pathToComposerHome;
 
         putenv('COMPOSER_HOME=' . $pathToComposerHome);
 
         $this->consoleApplication->setAutoExit(false);
-        $this->configIsSet = true;
-
     }
 
     /**
-     * Returns composer object
+     * Creates composer object
      *
      * @return \Composer\Composer
      * @throws \Exception
      */
-    public function getComposer()
+    public function createComposer()
     {
-        if (!$this->configIsSet) {
-            throw new \Exception('Please call setConfig method to configure composer');
-        }
-
         return ComposerFactory::create(new BufferIO(), $this->composerJson);
-
     }
 
     /**
      * Runs composer command
      *
      * @param array $commandParams
      * @return bool
-     * @throws \Exception
      * @throws \RuntimeException
      */
     public function runComposerCommand(array $commandParams)
     {
-        if (!$this->configIsSet) {
-            throw new \Exception('Please call setConfig method to configure composer');
-        }
-
         $this->consoleApplication->resetComposer();
 
         $commandParams[self::COMPOSER_WORKING_DIR] = dirname($this->composerJson);