From cb82e8c0bd4b2f0f93559dbee226ea07b138fb05 Mon Sep 17 00:00:00 2001 From: Bartosz Gorski Date: Fri, 2 Apr 2021 02:35:48 +0200 Subject: [PATCH 1/2] Modified the PR template to include README.md update reqirement if necessary --- .github/PULL_REQUEST_TEMPLATE.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 9daf68a10d2d..904084eb23e0 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -41,3 +41,4 @@ - [ ] All commits are accompanied by meaningful commit messages - [ ] All new or changed code is covered with unit/integration tests (if applicable) - [ ] All automated tests passed successfully (all builds are green) + - [ ] README.md files for modified modules are updated and included in the pull request if any [README.md predefined sections](https://github.com/magento/devdocs/wiki/Magento-module-README.md) require an update From 4937049eba9997b43f52e81e4066973e6bdb7786 Mon Sep 17 00:00:00 2001 From: Bartosz Gorski Date: Fri, 2 Apr 2021 02:58:26 +0200 Subject: [PATCH 2/2] Changed contribution checklist order to keep consistency --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 904084eb23e0..c9d67fe79971 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -40,5 +40,5 @@ - [ ] Pull request has a meaningful description of its purpose - [ ] All commits are accompanied by meaningful commit messages - [ ] All new or changed code is covered with unit/integration tests (if applicable) - - [ ] All automated tests passed successfully (all builds are green) - [ ] README.md files for modified modules are updated and included in the pull request if any [README.md predefined sections](https://github.com/magento/devdocs/wiki/Magento-module-README.md) require an update + - [ ] All automated tests passed successfully (all builds are green)