Fixed PHP 5.4 incompatibility in empty() call

vania-pooh · vania-pooh · commit b40553ba88c8 · 2014-08-18T19:54:48.000+04:00
diff --git a/src/Yandex/Allure/Adapter/AllureAdapter.php b/src/Yandex/Allure/Adapter/AllureAdapter.php
@@ -101,7 +101,7 @@ public function addFailure(PHPUnit_Framework_Test $test, PHPUnit_Framework_Asser
         // Append comparison diff for errors of type ExpectationFailedException (and is subclasses)
         if (($e instanceof PHPUnit_Framework_ExpectationFailedException
             || is_subclass_of($e, '\PHPUnit_Framework_ExpectationFailedException'))
-            && !empty($e->getComparisonFailure())
+            && $e->getComparisonFailure()
         ) {
             $message .= $e->getComparisonFailure()->getDiff();
         }

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ public function addFailure(PHPUnit_Framework_Test $test, PHPUnit_Framework_Asser`
`101`	`101`	`// Append comparison diff for errors of type ExpectationFailedException (and is subclasses)`
`102`	`102`	`if (($e instanceof PHPUnit_Framework_ExpectationFailedException`
`103`	`103`	`\|\| is_subclass_of($e, '\PHPUnit_Framework_ExpectationFailedException'))`
`104`		`- && !empty($e->getComparisonFailure())`
	`104`	`+ && $e->getComparisonFailure()`
`105`	`105`	`) {`
`106`	`106`	`$message .= $e->getComparisonFailure()->getDiff();`
`107`	`107`	`}`