MCLOUD-13313: Added functional test for PHP8.4 & removed unwanted code from Acceptance83Cest

Author: prateek-karanpuria-adobe

Test/Functional/Acceptance/Acceptance83Cest.php

@@ -12,89 +12,6 @@
  */
 class Acceptance83Cest extends AcceptanceCest
 {
-    /**
-     * @param \CliTester $I
-     */
-    public function _before(\CliTester $I): void
-    {
-        $I->cleanupWorkDir();
-    }
-
-    /**
-     * @param \CliTester $I
-     * @param string $magentoVersion
-     */
-    protected function prepareTemplate(\CliTester $I, string $magentoVersion): void
-    {
-        $I->cloneTemplateToWorkDir($magentoVersion);
-        $I->createAuthJson();
-        $I->createArtifactsDir();
-        $I->createArtifactCurrentTestedCode('components', '1.0.99');
-        $I->addArtifactsRepoToComposer();
-        $I->addDependencyToComposer('magento/magento-cloud-components', '1.0.99');
-
-        $I->addEceToolsGitRepoToComposer();
-        $I->addEceDockerGitRepoToComposer();
-        $I->addCloudPatchesGitRepoToComposer();
-        $I->addQualityPatchesGitRepoToComposer();
-
-        $dependencies = [
-            'magento/ece-tools',
-            'magento/magento-cloud-docker',
-            'magento/magento-cloud-patches',
-            'magento/quality-patches'
-        ];
-
-        foreach ($dependencies as $dependency) {
-            $I->assertTrue(
-                $I->addDependencyToComposer($dependency, $I->getDependencyVersion($dependency)),
-                'Can not add dependency ' . $dependency
-            );
-        }
-
-        $I->composerUpdate();
-    }
-
-    /**
-     * @param \CliTester $I
-     * @param \Codeception\Example $data
-     * @throws \Robo\Exception\TaskException
-     * @dataProvider patchesDataProvider
-     */
-    public function testPatches(\CliTester $I, \Codeception\Example $data): void
-    {
-        $this->prepareTemplate($I, $data['magentoVersion']);
-        $this->removeESIfExists($I, $data['magentoVersion']);
-        $I->generateDockerCompose('--mode=production');
-        $I->runDockerComposeCommand('run build cloud-build');
-        $I->startEnvironment();
-        $I->runDockerComposeCommand('run deploy cloud-deploy');
-        $I->runDockerComposeCommand('run deploy cloud-post-deploy');
-        $I->amOnPage('/');
-        $I->see('Home page');
-        $I->see('CMS homepage content goes here.');
-    }
-
-    /**
-     * @param \CliTester $I
-     * @param string $magentoVersion
-     */
-    protected function removeESIfExists(\CliTester $I, string $magentoVersion): void
-    {
-        if ($magentoVersion !== 'master' && version_compare($magentoVersion, '2.4.0', '<')) {
-            $services = $I->readServicesYaml();
-
-            if (isset($services['elasticsearch'])) {
-                unset($services['elasticsearch']);
-                $I->writeServicesYaml($services);
-
-                $app = $I->readAppMagentoYaml();
-                unset($app['relationships']['elasticsearch']);
-                $I->writeAppMagentoYaml($app);
-            }
-        }
-    }
-
     /**
      * @return array
      */
@@ -104,13 +21,4 @@ protected function patchesDataProvider(): array
             ['magentoVersion' => '2.4.7'],
         ];
     }
-
-    /**
-     * @param \CliTester $I
-     */
-    public function _after(\CliTester $I): void
-    {
-        $I->stopEnvironment();
-        $I->removeWorkDir();
-    }
 }

Test/Functional/Acceptance/Acceptance84Cest.php

@@ -0,0 +1,24 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+namespace Magento\CloudComponents\Test\Functional\Acceptance;
+
+/**
+ * @group php84
+ */
+class Acceptance83Cest extends AcceptanceCest
+{
+    /**
+     * @return array
+     */
+    protected function patchesDataProvider(): array
+    {
+        return [
+            ['magentoVersion' => '2.4.8'],
+        ];
+    }
+}