Skip to content

Commit 4836e31

Browse files
authored
MCLOUD-6028: Fix failed tests magento-cloud-docker (#219)
1 parent 60bcade commit 4836e31

File tree

2 files changed

+25
-13
lines changed

2 files changed

+25
-13
lines changed

composer.json

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,15 @@
1919
"symfony/yaml": "^3.3||^4.0"
2020
},
2121
"require-dev": {
22+
"codeception/codeception": "^4.1",
23+
"codeception/module-asserts": "^1.2",
24+
"codeception/module-db": "^1.0",
25+
"codeception/module-phpbrowser": "^1.0",
26+
"consolidation/robo": "^1.2",
2227
"phpmd/phpmd": "@stable",
2328
"phpstan/phpstan": "^0.11",
2429
"phpunit/phpunit": "^8.5",
25-
"squizlabs/php_codesniffer": "^3.0",
26-
"codeception/codeception": "^4.1",
27-
"consolidation/robo": "^1.2"
30+
"squizlabs/php_codesniffer": "^3.0"
2831
},
2932
"bin": [
3033
"bin/ece-docker"

src/Compose/ProductionBuilder.php

Lines changed: 19 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -224,21 +224,30 @@ public function build(Config $config): Manager
224224
continue;
225225
}
226226

227+
switch ($service) {
228+
case self::SERVICE_REDIS:
229+
$serviceConfig = [self::SERVICE_HEALTHCHECK => [
230+
'test'=> 'redis-cli ping || exit 1',
231+
'interval'=> '30s',
232+
'timeout'=> '30s',
233+
'retries'=> 3
234+
]];
235+
break;
236+
237+
case self::SERVICE_ELASTICSEARCH:
238+
$serviceConfig = !empty($esEnvVars) ? ['environment' => $esEnvVars] : [];
239+
break;
240+
241+
default:
242+
$serviceConfig = [];
243+
}
244+
227245
$manager->addService(
228246
$service,
229247
$this->serviceFactory->create(
230248
(string)$service,
231249
(string)$config->getServiceVersion($service),
232-
self::SERVICE_ELASTICSEARCH === $service && !empty($esEnvVars)
233-
? ['environment' => $esEnvVars]
234-
: self::SERVICE_REDIS === $service
235-
? [self::SERVICE_HEALTHCHECK => [
236-
'test'=> 'redis-cli ping || exit 1',
237-
'interval'=> '30s',
238-
'timeout'=> '30s',
239-
'retries'=> 3
240-
] ]
241-
: []
250+
$serviceConfig
242251
),
243252
[self::NETWORK_MAGENTO],
244253
[]

0 commit comments

Comments
 (0)