MCLOUD-11659: Add php 8.3 to magento-cloud-docker

Author: BaDos

src/Test/Functional/Acceptance/AcceptanceCest.php

@@ -28,9 +28,9 @@ public function testProductionMode(\CliTester $I): void
         $I->assertTrue($I->generateDockerCompose('--mode=production'), 'Command build:compose failed');
         $I->replaceImagesWithCustom();
         $I->startEnvironment();
-        $I->runDockerComposeCommand('run --rm build cloud-build');
-        $I->runDockerComposeCommand('run --rm deploy cloud-deploy');
-        $I->runDockerComposeCommand('run --rm deploy cloud-post-deploy');
+        $I->runDockerComposeCommand('run build cloud-build');
+        $I->runDockerComposeCommand('run deploy cloud-deploy');
+        $I->runDockerComposeCommand('run deploy cloud-post-deploy');
         $I->amOnPage('/');
         $I->see('Home page');
         $I->see('CMS homepage content goes here.');
@@ -51,9 +51,9 @@ public function testCustomHost(\CliTester $I): void
         );
         $I->replaceImagesWithCustom();
         $I->startEnvironment();
-        $I->assertTrue($I->runDockerComposeCommand('run --rm build cloud-build'), 'Build phase failed');
-        $I->assertTrue($I->runDockerComposeCommand('run --rm deploy cloud-deploy'), 'Deploy phase failed');
-        $I->assertTrue($I->runDockerComposeCommand('run --rm deploy cloud-post-deploy'), 'Post deploy phase failed');
+        $I->assertTrue($I->runDockerComposeCommand('run build cloud-build'), 'Build phase failed');
+        $I->assertTrue($I->runDockerComposeCommand('run deploy cloud-deploy'), 'Deploy phase failed');
+        $I->assertTrue($I->runDockerComposeCommand('run deploy cloud-post-deploy'), 'Post deploy phase failed');
         $I->amOnPage('/');
         $I->see('Home page');
         $I->see('CMS homepage content goes here.');

src/Test/Functional/Acceptance/DeveloperCest.php

@@ -31,10 +31,10 @@ public function testDevPhpIni(CliTester $I)
         $I->replaceImagesWithCustom();
         $I->startEnvironment();
 
-        $I->runDockerComposeCommand('run --rm deploy php -i | grep opcache.validate_timestamps');
+        $I->runDockerComposeCommand('run deploy php -i | grep opcache.validate_timestamps');
         $I->seeInOutput('=> On');
 
-        $I->runDockerComposeCommand('run --rm fpm php -i | grep opcache.validate_timestamps');
+        $I->runDockerComposeCommand('run fpm php -i | grep opcache.validate_timestamps');
         $I->seeInOutput('=> On');
     }
 }

src/Test/Functional/Acceptance/MailHogCest.php

@@ -61,7 +61,7 @@ private function runAndAssert(\CliTester $I): void
         $I->assertSame([0], $I->grabDataFromResponseByJsonPath('$.total'));
 
         $I->assertTrue(
-            $I->runDockerComposeCommand('run --rm deploy bash -c "php -r \"mail(\'[email protected]\',\'test\',\'test\');\""')
+            $I->runDockerComposeCommand('run deploy bash -c "php -r \"mail(\'[email protected]\',\'test\',\'test\');\""')
         );
         $I->sendAjaxGetRequest('/api/v2/messages', ['limit' => 10]);
         $I->seeResponseIsJson();

tests/functional/Codeception/Docker.php

@@ -108,7 +108,7 @@ public function runDockerComposeCommand(string $command): bool
     public function resetFilesOwner(): bool
     {
         return $this->runDockerComposeCommand(
-            'run --rm build bash -c "chown -R $(id -u):$(id -g) . /composer/cache"'
+            'run build bash -c "chown -R $(id -u):$(id -g) . /composer/cache"'
         );
     }
 

tests/functional/Robo/Tasks/DockerCompose/Run.php

@@ -63,7 +63,7 @@ public function __construct($container)
     public function getCommand()
     {
         return trim(sprintf(
-            'docker-compose run --rm -w %s %s %s ' . $this->runWrapper,
+            'docker-compose run -w %s %s %s ' . $this->runWrapper,
             escapeshellarg($this->workingDir),
             $this->arguments,
             escapeshellarg($this->container),

tests/functional/Robo/Tasks/EnvCleanUp.php

@@ -44,7 +44,7 @@ public function getCommand(): string
 
         foreach ($this->volumes as $volume) {
             $commands[] = sprintf(
-                'docker-compose run --rm %s bash -c "mkdir -p %s"',
+                'docker-compose run %s bash -c "mkdir -p %s"',
                 Docker::BUILD_CONTAINER,
                 $volume
             );