MAGECLOUD-5181: Disable cron container by default (#144)

Author: shiftedreality

src/Command/BuildCompose.php

@@ -50,7 +50,7 @@ class BuildCompose extends Command
     private const OPTION_NODE = 'node';
     private const OPTION_MODE = 'mode';
     private const OPTION_SYNC_ENGINE = 'sync-engine';
-    private const OPTION_NO_CRON = 'no-cron';
+    private const OPTION_WITH_CRON = 'with-cron';
     private const OPTION_WITH_SELENIUM = 'with-selenium';
 
     /**
@@ -209,10 +209,10 @@ protected function configure(): void
                 DeveloperBuilder::SYNC_ENGINE_DOCKER_SYNC
             )
             ->addOption(
-                self::OPTION_NO_CRON,
+                self::OPTION_WITH_CRON,
                 null,
                 InputOption::VALUE_NONE,
-                'Remove cron container'
+                'Add cron container'
             )
             ->addOption(
                 self::OPTION_WITH_SELENIUM,
@@ -254,7 +254,7 @@ public function execute(InputInterface $input, OutputInterface $output)
 
         $config->set([
             DeveloperBuilder::KEY_SYNC_ENGINE => $syncEngine,
-            ProductionBuilder::KEY_NO_CRON => $input->getOption(self::OPTION_NO_CRON),
+            ProductionBuilder::KEY_WITH_CRON=> $input->getOption(self::OPTION_WITH_CRON),
             ProductionBuilder::KEY_WITH_SELENIUM => $input->getOption(self::OPTION_WITH_SELENIUM)
         ]);
 

src/Compose/FunctionalBuilder.php

@@ -86,7 +86,6 @@ public function build(): array
      */
     public function setConfig(Repository $config): void
     {
-        $config->set(self::KEY_NO_CRON, true);
         $config->set(self::KEY_WITH_SELENIUM, false);
         $config->set(self::KEY_NO_TMP_MOUNTS, true);
 

src/Compose/ProductionBuilder.php

@@ -33,7 +33,7 @@ class ProductionBuilder implements BuilderInterface
     public const SERVICE_PHP_CLI = ServiceFactory::SERVICE_CLI;
     public const SERVICE_PHP_FPM = ServiceFactory::SERVICE_FPM;
 
-    public const KEY_NO_CRON = 'no-cron';
+    public const KEY_WITH_CRON = 'with-cron';
     public const KEY_EXPOSE_DB_PORT = 'expose-db-port';
     public const KEY_NO_TMP_MOUNTS = 'no-tmp-mounts';
     public const KEY_WITH_SELENIUM = 'with-selenium';
@@ -296,7 +296,7 @@ public function build(): array
             ]
         );
 
-        if (!$this->config->get(self::KEY_NO_CRON, false)) {
+        if ($this->config->get(self::KEY_WITH_CRON, false)) {
             $services['cron'] = $this->getCronCliService(
                 $phpVersion,
                 true,