Skip to content

Commit ef2d43c

Browse files
authored
MCLOUD-7095: Remove alpine image from generic service (#5)
1 parent 3f17821 commit ef2d43c

File tree

6 files changed

+8
-7
lines changed

6 files changed

+8
-7
lines changed

src/Compose/ProductionBuilder/Service/Generic.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
use Magento\CloudDocker\Config\Config;
1414
use Magento\CloudDocker\Config\Environment\Converter;
1515
use Magento\CloudDocker\Service\ServiceFactory;
16+
use Magento\CloudDocker\Service\ServiceInterface;
1617

1718
/**
1819
* Returns Generic service configuration
@@ -72,7 +73,7 @@ public function getConfig(Config $config): array
7273
{
7374
return $this->serviceFactory->create(
7475
$this->getServiceName(),
75-
$config->getServiceVersion($this->getServiceName()),
76+
$config->getServiceVersion(ServiceInterface::SERVICE_PHP),
7677
[
7778
'env_file' => './.docker/config.env',
7879
'environment' => $this->converter->convert(

src/Service/ServiceFactory.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,9 +109,9 @@ class ServiceFactory
109109
'pattern' => self::PATTERN_STD
110110
],
111111
ServiceInterface::SERVICE_GENERIC => [
112-
'image' => 'alpine',
112+
'image' => 'magento/magento-cloud-docker-php',
113113
'version' => 'latest',
114-
'pattern' => self::PATTERN_STD
114+
'pattern' => '%s:%s-cli-%s'
115115
],
116116
ServiceInterface::SERVICE_SELENIUM => [
117117
'image' => 'selenium/standalone-chrome',

src/Test/Integration/_files/cloud_base/docker-compose.exp.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ services:
119119
condition: service_started
120120
generic:
121121
hostname: generic.magento2.docker
122-
image: 'alpine:latest'
122+
image: 'magento/magento-cloud-docker-php:7.3-cli-1.1'
123123
env_file: ./.docker/config.env
124124
environment:
125125
- 'PHP_EXTENSIONS=bcmath bz2 calendar exif gd gettext intl mysqli pcntl pdo_mysql soap sockets sysvmsg sysvsem sysvshm opcache zip redis xsl sodium'

src/Test/Integration/_files/cloud_base_mftf/docker-compose.exp.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ services:
173173
condition: service_started
174174
generic:
175175
hostname: generic.magento2.docker
176-
image: 'alpine:latest'
176+
image: 'magento/magento-cloud-docker-php:7.3-cli-1.1'
177177
env_file: ./.docker/config.env
178178
environment:
179179
- 'PHP_EXTENSIONS=bcmath bz2 calendar exif gd gettext intl mysqli pcntl pdo_mysql soap sockets sysvmsg sysvsem sysvshm opcache zip redis xsl sodium'

src/Test/Integration/_files/cloud_base_test/docker-compose.exp.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ services:
160160
condition: service_started
161161
generic:
162162
hostname: generic.magento2.docker
163-
image: 'alpine:latest'
163+
image: 'magento/magento-cloud-docker-php:7.3-cli-1.1'
164164
env_file: ./.docker/config.env
165165
environment:
166166
- 'PHP_EXTENSIONS=bcmath bz2 calendar exif gd gettext intl mysqli pcntl pdo_mysql soap sockets sysvmsg sysvsem sysvshm opcache zip redis xsl sodium'

src/Test/Integration/_files/custom_cloud_base/docker-compose.exp.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ services:
9393
condition: service_started
9494
generic:
9595
hostname: generic.magento2.test
96-
image: 'alpine:latest'
96+
image: 'magento/magento-cloud-docker-php:7.2-cli-1.1'
9797
env_file: ./.docker/config.env
9898
environment:
9999
- 'PHP_EXTENSIONS=bcmath bz2 calendar exif gd gettext intl mysqli pcntl pdo_mysql soap sockets sysvmsg sysvsem sysvshm opcache zip xsl'

0 commit comments

Comments
 (0)