MAGECLOUD-5127: Update Constraints for Magento 2.4 (#19)

Author: bbatsche

composer.json

@@ -8,14 +8,12 @@
         "php": "^7.0",
         "ext-json": "*",
         "composer/composer": "@stable",
+        "composer/semver": "^1.5",
         "symfony/config": "^3.3||^4.3",
         "symfony/console": "^2.6||^4.0",
         "symfony/dependency-injection": "^3.3||^4.3",
         "symfony/process": "^2.1||^4.1"
     },
-    "conflict": {
-        "symfony/process": "^4.2"
-    },
     "require-dev": {
         "phpmd/phpmd": "@stable",
         "phpunit/phpunit": "^6.2",

config/services.xml

@@ -13,5 +13,6 @@
         <service id="Magento\CloudPatches\Command\Patch\ManagerException" autowire="false"/>
         <service id="Magento\CloudPatches\Patch\ApplierException" autowire="false"/>
         <service id="Magento\CloudPatches\Filesystem\FileNotFoundException" autowire="false"/>
+        <service id="Magento\CloudPatches\Shell\PackageNotFoundException" autowire="false"/>
     </services>
 </container>

src/Shell/PackageNotFoundException.php

@@ -0,0 +1,17 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+namespace Magento\CloudPatches\Shell;
+
+use Magento\CloudPatches\App\GenericException;
+
+/**
+ * Exception if a Composer package could not be found for some reason (e.g., symfony/process).
+ */
+class PackageNotFoundException extends GenericException
+{
+}

src/Shell/ProcessFactory.php

@@ -7,6 +7,9 @@
 
 namespace Magento\CloudPatches\Shell;
 
+use Composer\Composer;
+use Composer\Repository\RepositoryInterface;
+use Composer\Semver\Comparator;
 use Magento\CloudPatches\Filesystem\DirectoryList;
 use Symfony\Component\Process\Process;
 
@@ -17,17 +20,25 @@
  */
 class ProcessFactory
 {
+    const ARRAY_PARAM_MIN_VERSION = '3.3.0';
+
     /**
      * @var DirectoryList
      */
     private $directoryList;
 
+    /**
+     * @var RepositoryInterface
+     */
+    private $repository;
+
     /**
      * @param DirectoryList $directoryList
      */
-    public function __construct(DirectoryList $directoryList)
+    public function __construct(DirectoryList $directoryList, Composer $composer)
     {
         $this->directoryList = $directoryList;
+        $this->repository = $composer->getLocker()->getLockedRepository();
     }
 
     /**
@@ -37,8 +48,22 @@ public function __construct(DirectoryList $directoryList)
     public function create(array $cmd): Process
     {
         return new Process(
-            implode(' ', $cmd),
+            $this->processSupportsArrayParam() ? $cmd : implode(' ', $cmd),
             $this->directoryList->getMagentoRoot()
         );
     }
+
+    /**
+     * Test if symfony/process is current enough to support an array for its first parameter.
+     */
+    private function processSupportsArrayParam(): bool
+    {
+        $package = $this->repository->findPackage('symfony/process', '*');
+
+        if ($package === null) {
+            throw new PackageNotFoundException('Could not find symfony/process package.');
+        }
+
+        return Comparator::greaterThanOrEqualTo($package->getVersion(), self::ARRAY_PARAM_MIN_VERSION);
+    }
 }