Skip to content

Commit 5e4b15b

Browse files
committed
AC-660: Create phpcs static check for DiConfigTest
- Update XML files
1 parent d8d8cb7 commit 5e4b15b

File tree

2 files changed

+18
-12
lines changed

2 files changed

+18
-12
lines changed

Magento2/Tests/Legacy/DiConfigUnitTest.xml

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,19 @@
55
* See COPYING.txt for license details.
66
*/
77
-->
8-
<root>
8+
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
9+
<type>
10+
<arguments>
11+
<argument name="prices" xsi:type="array">
12+
<item key="regular_price" xsi:type="string">Magento\Catalog\Pricing\Price\RegularPrice</item>
13+
</argument>
14+
</arguments>
15+
</type>
916
<instance>
10-
<param name="param1" new_attribute="2">
11-
<array key="amounts">
12-
<item key="item1" new_attribute="3">
13-
<value new_attribute="4">scalar20</value>
14-
</item>
15-
<item>50.00</item>
16-
</array>
17-
</param>
17+
<array key="params">
18+
<param name="default_value" new_attribute="0">
19+
<value new_attribute="5">scalar5</value>
20+
</param>
21+
</array>
1822
</instance>
19-
</root>
23+
</config>

Magento2/ruleset.xml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<description>Magento Coding Standard</description>
44

55
<!-- File extensions to be checked. -->
6-
<arg name="extensions" value="php,phtml,graphqls/GraphQL,less/CSS,html/PHP"/>
6+
<arg name="extensions" value="php,phtml,graphqls/GraphQL,less/CSS,html/PHP,xml"/>
77

88
<!-- Severity 10 errors: Critical code issues. -->
99
<rule ref="Generic.Functions.CallTimePassByReference">
@@ -224,9 +224,10 @@
224224
<type>warning</type>
225225
</rule>
226226
<rule ref="Magento2.Legacy.DiConfig">
227+
<include-pattern>*\/di.xml$</include-pattern>
228+
<include-pattern>*\/DiConfigUnitTest.xml$</include-pattern>
227229
<severity>8</severity>
228230
<type>warning</type>
229-
<include-pattern>*\/di.xml$</include-pattern>
230231
</rule>
231232

232233
<!-- Severity 7 warnings: General code issues. -->
@@ -263,6 +264,7 @@
263264
<type>warning</type>
264265
</rule>
265266
<rule ref="Generic.PHP.DisallowShortOpenTag">
267+
<exclude-pattern>*\.xml$</exclude-pattern>
266268
<severity>7</severity>
267269
<type>warning</type>
268270
</rule>

0 commit comments

Comments
 (0)