AC-662: Create phpcs static check for AutogeneratedClassNotInConstructorTest

Author: jcuerdo

Magento2/Sniffs/PHP/AutogeneratedClassNotInConstructorSniff.php

@@ -63,7 +63,7 @@ public function process(File $phpcsFile, $stackPtr)
             if ($variable = $phpcsFile->findNext(T_VARIABLE, $equalsPtr, $statementEnd)) {
                 $variableName = $phpcsFile->getTokens()[$variable]['content'];
                 if ($variableName === '$this') {
-                   $variableName = $this->getNext($phpcsFile, $variable, $statementEnd, T_STRING)['content'];
+                    $variableName = $this->getNext($phpcsFile, $variable, $statementEnd, T_STRING)['content'];
                 }
                 foreach ($this->constructorParameters as $parameter) {
                     $parameterName = $parameter['name'];
@@ -188,10 +188,12 @@ private function getPrevious(File $phpcsFile, int $from, $types)
     }
 
     /**
-     * @param $parameterName
-     * @return array|string|string[]
+     * Get name of the variable without $
+     *
+     * @param string $parameterName
+     * @return string
      */
-    protected function variableName($parameterName)
+    protected function variableName(string $parameterName): string
     {
         return str_replace('$', '', $parameterName);
     }