AC-661: Create phpcs static check for XmlTest

Author: jcuerdo

Magento2/Sniffs/Legacy/WidgetXMLSniff.php

@@ -38,9 +38,22 @@ public function process(File $phpcsFile, $stackPtr)
             return;
         }
 
-        $xml = simplexml_load_string($this->getFormattedXML($phpcsFile));
+        try{
+            $xml = simplexml_load_string($this->getFormattedXML($phpcsFile));
+        } catch (\Exception $e) {
+            $phpcsFile->addError(
+                sprintf(
+                    "Couldn't parse contents of '%s', check that they are in valid XML format",
+                    $phpcsFile->getFilename(),
+                ),
+                $stackPtr,
+                self::ERROR_CODE_XML
+            );
+            return;
+        }
 
         $foundElements = $xml->xpath('/widgets/*[@type]');
+
         foreach ($foundElements as $element) {
             if (!property_exists($element->attributes(), 'type')) {
                 continue;

Magento2/Tests/Legacy/WidgetXMLUnitTest.2.xml

@@ -0,0 +1,11 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+-->
+<widgets>
+    <widget
+</widgets>
+

Magento2/Tests/Legacy/WidgetXMLUnitTest.php

@@ -14,11 +14,19 @@ class WidgetXMLUnitTest extends AbstractSniffUnitTest
      */
     public function getErrorList($testFile = '')
     {
-        return [
-            9 => 1,
-            12 => 1,
-            14 => 1,
-        ];
+        if ($testFile === 'WidgetXMLUnitTest.1.xml') {
+            return [
+                9 => 1,
+                12 => 1,
+                14 => 1,
+            ];
+        }
+        if ($testFile === 'WidgetXMLUnitTest.2.xml') {
+            return [
+                1 => 1
+            ];
+        }
+        return [];
     }
 
     /**