Skip to content

Commit f7f1a0d

Browse files
committed
AC-670: Create phpcs static check for LayoutTest
1 parent f16142d commit f7f1a0d

File tree

1 file changed

+19
-0
lines changed

1 file changed

+19
-0
lines changed

Magento2/Sniffs/Legacy/LayoutSniff.php

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,11 @@ class LayoutSniff implements Sniff
7171
],
7272
];
7373

74+
/**
75+
* List of allowed method names
76+
*
77+
* @var string[]
78+
*/
7479
private $allowedActionNodeMethods = [
7580
'addBodyClass',
7681
'addButtons',
@@ -233,6 +238,9 @@ public function process(File $phpcsFile, $stackPtr)
233238
}
234239

235240
/**
241+
* Check for obsolete block references
242+
*
243+
* @todo missing test
236244
* @param SimpleXMLElement $layout
237245
* @param File $phpcsFile
238246
*/
@@ -269,6 +277,8 @@ private function getFormattedXML(File $phpcsFile)
269277
}
270278

271279
/**
280+
* Check that CSS, Link and Script blocks are inside a head block
281+
*
272282
* @param SimpleXMLElement $layout
273283
* @param File $phpcsFile
274284
*/
@@ -295,6 +305,8 @@ private function testHeadBlocks(SimpleXMLElement $layout, File $phpcsFile): void
295305
}
296306

297307
/**
308+
* Check that the output attribute has the right value
309+
*
298310
* @param SimpleXMLElement $layout
299311
* @param File $phpcsFile
300312
*/
@@ -347,6 +359,7 @@ private function testObsoleteAttributes(SimpleXMLElement $layout, File $phpcsFil
347359
/**
348360
* Returns attribute value by attribute name
349361
*
362+
* @param SimpleXMLElement $element
350363
* @param string $name
351364
* @return string|null
352365
*/
@@ -357,6 +370,8 @@ private function getAttribute(SimpleXMLElement $element, string $name): string
357370
}
358371

359372
/**
373+
* Check values in helper attributes
374+
*
360375
* @param SimpleXMLElement $layout
361376
* @param File $phpcsFile
362377
*/
@@ -381,6 +396,8 @@ private function testHelperAttribute(SimpleXMLElement $layout, File $phpcsFile):
381396
}
382397

383398
/**
399+
* Check that ListText is not used
400+
*
384401
* @param SimpleXMLElement $layout
385402
* @param File $phpcsFile
386403
*/
@@ -398,6 +415,8 @@ private function testListText(SimpleXMLElement $layout, File $phpcsFile): void
398415
}
399416

400417
/**
418+
* Check that action is calling an allowed method
419+
*
401420
* @param SimpleXMLElement $layout
402421
* @param File $phpcsFile
403422
*/

0 commit comments

Comments
 (0)