Skip to content

Commit 27d4667

Browse files
committed
fix static tests failures
1 parent 057b36c commit 27d4667

File tree

7 files changed

+24
-14
lines changed

7 files changed

+24
-14
lines changed

src/Analyzer/EtSchemaAnalyzer.php

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
<?php
2+
23
/**
34
* Copyright © Magento, Inc. All rights reserved.
45
* See COPYING.txt for license details.
56
*/
7+
68
declare(strict_types=1);
79

810
namespace Magento\SemanticVersionChecker\Analyzer;
@@ -22,7 +24,7 @@ class EtSchemaAnalyzer implements AnalyzerInterface
2224
/**
2325
* Analyser context
2426
*/
25-
const CONTEXT = 'etSchema';
27+
public const CONTEXT = 'etSchema';
2628

2729
/**
2830
* @var array of actions
@@ -228,7 +230,8 @@ private function analyzeRecord(string $moduleName, $beforeRecord, $afterRecord):
228230
array_keys($afterRecord['field'])
229231
);
230232
foreach ($commonFields as $fieldName) {
231-
if ($beforeRecord['field'][$fieldName]['type'] != $afterRecord['field'][$fieldName]['type']
233+
if (
234+
$beforeRecord['field'][$fieldName]['type'] != $afterRecord['field'][$fieldName]['type']
232235
|| $beforeRecord['field'][$fieldName]['repeated'] != $afterRecord['field'][$fieldName]['repeated']
233236
) {
234237
$changes[] = $this->changedField($moduleName, $beforeRecord['name'], $fieldName);
@@ -310,11 +313,11 @@ public function reportChanges(array $changes): void
310313
$this->report->add(
311314
self::CONTEXT,
312315
new EtSchemaOperation(
313-
$change['location'],
314-
$change['code'],
315-
$change['target'],
316-
$change['reason'],
317-
$change['level']
316+
$change['location'],
317+
$change['code'],
318+
$change['target'],
319+
$change['reason'],
320+
$change['level']
318321
)
319322
);
320323
}
@@ -329,7 +332,6 @@ public function reportChanges(array $changes): void
329332
*/
330333
public function analyze($registryBefore, $registryAfter)
331334
{
332-
333335
$before = isset($registryBefore->data[self::CONTEXT]) ? $registryBefore->data[self::CONTEXT] : [];
334336
$after = isset($registryAfter->data[self::CONTEXT]) ? $registryAfter->data[self::CONTEXT] : [];
335337
$changes = [];

src/Analyzer/Factory/EtSchemaAnalyzerFactory.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
<?php
2+
23
/**
34
* Copyright © Magento, Inc. All rights reserved.
45
* See COPYING.txt for license details.
56
*/
7+
68
declare(strict_types=1);
79

810
namespace Magento\SemanticVersionChecker\Analyzer\Factory;
911

10-
1112
use Magento\SemanticVersionChecker\Analyzer\Analyzer;
1213
use Magento\SemanticVersionChecker\Analyzer\AnalyzerInterface;
1314
use Magento\SemanticVersionChecker\Analyzer\EtSchemaAnalyzer;

src/Operation/EtSchema/EtSchemaOperation.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,15 @@
11
<?php
2+
23
/**
34
* Copyright © Magento, Inc. All rights reserved.
45
* See COPYING.txt for license details.
56
*/
7+
68
declare(strict_types=1);
79

810
namespace Magento\SemanticVersionChecker\Operation\EtSchema;
911

10-
use \PHPSemVerChecker\Operation\Operation;
12+
use PHPSemVerChecker\Operation\Operation;
1113

1214
/**
1315
* Class EtSchemaOperation
@@ -37,7 +39,7 @@ public function __construct(
3739
string $target,
3840
string $reason,
3941
int $level
40-
){
42+
) {
4143
$this->location = $location;
4244
$this->target = $target;
4345
$this->code = $code;
@@ -68,4 +70,4 @@ public function getLevel()
6870
{
6971
return $this->level;
7072
}
71-
}
73+
}

src/ReportTypes.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
namespace Magento\SemanticVersionChecker;
1111

1212
use Magento\SemanticVersionChecker\Analyzer\EtSchemaAnalyzer;
13+
1314
/**
1415
* Holds the different report type keys.
1516
*/

src/Reporter/HtmlDbSchemaReporter.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
use Symfony\Component\Console\Input\InputInterface;
1616
use Symfony\Component\Console\Output\OutputInterface;
1717
use Magento\SemanticVersionChecker\Analyzer\EtSchemaAnalyzer;
18+
1819
/**
1920
* @package Magento\SemanticVersionChecker
2021
*/

src/Scanner/EtSchema/XmlConverter.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
<?php
2+
23
/**
34
* Copyright © Magento, Inc. All rights reserved.
45
* See COPYING.txt for license details.
56
*/
7+
68
declare(strict_types=1);
79

810
namespace Magento\SemanticVersionChecker\Scanner\EtSchema;
@@ -89,10 +91,9 @@ private function structureRecords(array $configData): array
8991
* @param \DOMDocument $source
9092
* @return array
9193
*/
92-
public function convert(\DOMNode $source) : array
94+
public function convert(\DOMNode $source): array
9395
{
9496
$configData = $this->convertNode($source);
9597
return $this->structureRecords($configData);
96-
9798
}
9899
}

src/Scanner/EtSchemaScanner.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
<?php
2+
23
/**
34
* Copyright © Magento, Inc. All rights reserved.
45
* See COPYING.txt for license details.
56
*/
7+
68
declare(strict_types=1);
79

810
namespace Magento\SemanticVersionChecker\Scanner;

0 commit comments

Comments
 (0)