Skip to content

Commit 5d2c4e1

Browse files
committed
EQPS-213 : Changes made from review.
1 parent 7c54fcf commit 5d2c4e1

File tree

5 files changed

+15
-199
lines changed

5 files changed

+15
-199
lines changed

src/FileChangeDetector.php

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,28 @@ public function __construct($sourceBeforeDir, $sourceAfterDir)
1919
$this->sourceAfterDir = $sourceAfterDir;
2020
}
2121

22+
/**
23+
* Get files that have changed
24+
*
25+
* @return array
26+
*/
2227
public function getChangedFiles()
2328
{
24-
$sourceBeforeFiles = self::getFiles([$this->sourceBeforeDir], '*', true);
25-
$sourceAfterFiles = self::getFiles([$this->sourceAfterDir], '*', true);
29+
$sourceBeforeFiles = $this->getFiles([$this->sourceBeforeDir], '*', true);
30+
$sourceAfterFiles = $this->getFiles([$this->sourceAfterDir], '*', true);
2631
$identicalFilter = new SourceFilter();
2732
$identicalFilter->filter($sourceBeforeFiles, $sourceAfterFiles);
2833
return array_merge($sourceAfterFiles, $sourceBeforeFiles);
2934
}
3035

36+
/**
37+
* Retrieve all files in folders and sub-folders that match pattern (glob syntax)
38+
*
39+
* @param array $dirPatterns
40+
* @param string $fileNamePattern
41+
* @param bool $recursive
42+
* @return array
43+
*/
3144
public function getFiles(array $dirPatterns, $fileNamePattern, $recursive = true)
3245
{
3346
$result = [];

src/Helper/Phrase.php

Lines changed: 0 additions & 129 deletions
This file was deleted.

src/Helper/Placeholder.php

Lines changed: 0 additions & 45 deletions
This file was deleted.

src/Helper/RendererInterface.php

Lines changed: 0 additions & 21 deletions
This file was deleted.

tests/Unit/bootstrap.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@
1212

1313
setCustomErrorHandler();
1414

15-
\Magento\SemanticVersionChecker\Helper\Phrase::setRenderer(new \Magento\SemanticVersionChecker\Helper\Placeholder());
16-
1715
error_reporting(E_ALL);
1816
ini_set('display_errors', 1);
1917

0 commit comments

Comments
 (0)