Skip to content

Commit 65e0bd6

Browse files
glo71317glo71317
committed
AC-6945::SVC false-positive build failures, fixed unit tests
1 parent 33e6793 commit 65e0bd6

File tree

4 files changed

+19
-21
lines changed

4 files changed

+19
-21
lines changed

‎dev/tests/Unit/Console/Command/CompareSourceCommandApiClassesTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,10 @@ public function changesDataProvider()
5959
$pathToFixtures . '/new-method/source-code-before',
6060
$pathToFixtures . '/new-method/source-code-after',
6161
[
62-
'Class (MINOR)',
62+
'Class (PATCH)',
6363
'Test\Vcs\TestClass::testMethod | [public] Method has been added. | V015'
6464
],
65-
'Minor change is detected.'
65+
'Patch change is detected.'
6666
],
6767
'api-class-removed-class' => [
6868
$pathToFixtures . '/removed-class/source-code-before',
@@ -77,10 +77,10 @@ public function changesDataProvider()
7777
$pathToFixtures . '/removed-method/source-code-before',
7878
$pathToFixtures . '/removed-method/source-code-after',
7979
[
80-
'Class (MAJOR)',
80+
'Class (PATCH)',
8181
'Test\Vcs\TestClass::testMethod | [public] Method has been removed. | V006'
8282
],
83-
'Major change is detected.'
83+
'Patch change is detected.'
8484
],
8585
'api-class-new-required-method-parameter' => [
8686
$pathToFixtures . '/new-required-method-parameter/source-code-before',

‎dev/tests/Unit/Console/Command/CompareSourceCommandDiXmlTest.php

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -83,41 +83,41 @@ public function changesDataProvider()
8383
$pathToFixtures . '/moved-to-specific/source-code-before',
8484
$pathToFixtures . '/moved-to-specific/source-code-after',
8585
[
86-
'#Suggested semantic versioning change: MAJOR#',
87-
'#MAJOR\s*\|\s' . '[\w/]+' . '/moved-to-specific/source-code-before/Magento/TestModule/etc/di\.xml:0#',
86+
'#Suggested semantic versioning change: PATCH#',
87+
'#PATCH\s*\|\s' . '[\w/]+' . '/moved-to-specific/source-code-before/Magento/TestModule/etc/di\.xml:0#',
8888
'#scope\s*\|\s*Virtual Type was changed\s*\|\s*M201#'
8989
],
90-
'Major change is detected.',
90+
'Patch change is detected.',
9191
],
9292
'remove-type' => [
9393
$pathToFixtures . '/remove-type/source-code-before',
9494
$pathToFixtures . '/remove-type/source-code-after',
9595
[
96-
'#Suggested semantic versioning change: MAJOR#',
97-
'#MAJOR\s*\|\s' . '[\w/]+' . 'remove-type/source-code-before/Magento/TestModule/etc/di\.xml:0#',
96+
'#Suggested semantic versioning change: PATCH#',
97+
'#PATCH\s*\|\s' . '[\w/]+' . 'remove-type/source-code-before/Magento/TestModule/etc/di\.xml:0#',
9898
'#customCacheInstance2\s*\|\s*Virtual Type was removed\s*\|\s*M200\s*#'
9999
],
100-
'Major change is detected.',
100+
'Patch change is detected.',
101101
],
102102
'change-type' => [
103103
$pathToFixtures . '/change-type/source-code-before',
104104
$pathToFixtures . '/change-type/source-code-after',
105105
[
106-
'#Suggested semantic versioning change: MAJOR#',
107-
'#MAJOR\s*\|\s' . '[\w/]+' . '/change-type/source-code-before/Magento/TestModule/etc/di\.xml:0#',
106+
'#Suggested semantic versioning change: PATCH#',
107+
'#PATCH\s*\|\s' . '[\w/]+' . '/change-type/source-code-before/Magento/TestModule/etc/di\.xml:0#',
108108
'#type\s*\|\s*Virtual Type was changed\s*\|\s*M201#'
109109
],
110-
'Major change is detected.',
110+
'Patch change is detected.',
111111
],
112112
'change-name' => [
113113
$pathToFixtures . '/change-name/source-code-before',
114114
$pathToFixtures . '/change-name/source-code-after',
115115
[
116-
'#Suggested semantic versioning change: MAJOR#',
117-
'#MAJOR\s*\|\s*' . '[\w/]+' . '/change-name/source-code-before/Magento/TestModule/etc/di\.xml:0#',
116+
'#Suggested semantic versioning change: PATCH#',
117+
'#PATCH\s*\|\s*' . '[\w/]+' . '/change-name/source-code-before/Magento/TestModule/etc/di\.xml:0#',
118118
'#cacheInstance\s*\|\s*Virtual Type was removed\s*\|\s*M200#'
119119
],
120-
'Major change is detected.',
120+
'Patch change is detected.',
121121
],
122122
'removing-leading-slash-from-type' => [
123123
$pathToFixtures . '/removing-leading-slash-from-type/source-code-before',

‎dev/tests/Unit/Console/Command/HierarchyTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,9 @@ public function changesDataProvider()
4747
$pathToFixtures . '/public-method-removed-from-non-api-parent-class-extended-by-api-class/source-code-before',
4848
$pathToFixtures . '/public-method-removed-from-non-api-parent-class-extended-by-api-class/source-code-after',
4949
[
50-
'Suggested semantic versioning change: MAJOR',
50+
'Suggested semantic versioning change: PATCH',
5151
],
52-
'Major change is detected.',
52+
'Patch change is detected.',
5353
],
5454
'public-method-removed-from-non-api-trait-used-by-api-class' => [
5555
$pathToFixtures . '/public-method-removed-from-non-api-trait-used-by-api-class/source-code-before',

‎dev/tests/Unit/Console/Command/HtmlTest.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ public function changesDataProvider()
8181
['name' => 'test/api-trait', 'level' => 'MAJOR' ],
8282
['name' => 'test/layout_xml', 'level' => 'MAJOR' ],
8383
['name' => 'test/db_schema', 'level' => 'MAJOR' ],
84-
['name' => 'test/di_xml', 'level' => 'MAJOR' ],
84+
['name' => 'test/di_xml', 'level' => 'PATCH' ],
8585
['name' => 'test/system_xml', 'level' => 'MAJOR' ],
8686
['name' => 'test/xsd-schema', 'level' => 'MAJOR' ],
8787
['name' => 'test/less', 'level' => 'MAJOR' ],
@@ -103,7 +103,6 @@ public function changesDataProvider()
103103
['name' => 'test/api-trait', 'level' => 'MAJOR' ],
104104
['name' => 'test/layout_xml', 'level' => 'MAJOR' ],
105105
['name' => 'test/db_schema', 'level' => 'MAJOR' ],
106-
['name' => 'test/di_xml', 'level' => 'MAJOR' ],
107106
['name' => 'test/system_xml', 'level' => 'MAJOR' ],
108107
['name' => 'test/xsd-schema', 'level' => 'MAJOR' ],
109108
['name' => 'test/less', 'level' => 'MAJOR' ],
@@ -125,7 +124,6 @@ public function changesDataProvider()
125124
['name' => 'test/api-trait', 'level' => 'MAJOR' ],
126125
['name' => 'test/layout_xml', 'level' => 'MAJOR' ],
127126
['name' => 'test/db_schema', 'level' => 'MAJOR' ],
128-
['name' => 'test/di_xml', 'level' => 'MAJOR' ],
129127
['name' => 'test/system_xml', 'level' => 'MAJOR' ],
130128
['name' => 'test/xsd-schema', 'level' => 'MAJOR' ],
131129
['name' => 'test/less', 'level' => 'MAJOR' ],

0 commit comments

Comments
 (0)