Latest code from Infra on Nov01, updated namespaces, updated composer

Author: magterskine

composer.json

@@ -8,9 +8,9 @@
     ],
     "bin": ["bin/svc"],
     "require": {
-        "php": "~7.1.3||~7.2.0",
+        "php": "~7.1.3||~7.2.0||~7.3.0",
         "tomzx/php-semver-checker": "^0.13.0",
-        "symfony/console": "~4.1.0",
+        "symfony/console": "~4.0.0",
         "nikic/php-parser": "^3.1.0"
     },
     "require-dev": {

src/Analyzer/AbstractCodeAnalyzer.php

@@ -3,10 +3,11 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
-namespace Magento\SemanticVersionChecker\Analyzer;
+namespace Magento\SemanticVersionCheckr\Analyzer;
 
-use Magento\SemanticVersionChecker\Helper\ClassParser;
+use Magento\SemanticVersionCheckr\Helper\ClassParser;
 use PhpParser\Node;
 use PhpParser\Node\Stmt\Class_;
 use PhpParser\Node\Stmt\ClassLike;
@@ -48,26 +49,26 @@ public function __construct($context = null, $fileBefore = null, $fileAfter = nu
         $this->fileAfter = $fileAfter;
     }
 
-    public function analyze($contextBefore, $contextAfter)
+    public function analyze($registryBefore, $registryAfter)
     {
         $report = new Report();
 
-        $beforeNameMap = $this->getNodeNameMap($contextBefore);
-        $afterNameMap = $this->getNodeNameMap($contextAfter);
+        $beforeNameMap = $this->getNodeNameMap($registryBefore);
+        $afterNameMap = $this->getNodeNameMap($registryAfter);
 
         $namesBefore = array_keys($beforeNameMap);
         $namesAfter = array_keys($afterNameMap);
         $added = array_diff($namesAfter, $namesBefore);
         $removed = array_diff($namesBefore, $namesAfter);
         $toVerify = array_intersect($namesBefore, $namesAfter);
 
-        $this->reportAdded($report, $contextAfter, $added);
-        $this->reportMovedOrRemoved($report, $contextBefore, $contextAfter, $removed);
+        $this->reportAdded($report, $registryAfter, $added);
+        $this->reportMovedOrRemoved($report, $registryBefore, $registryAfter, $removed);
 
         $this->reportChanged(
             $report,
-            $contextBefore,
-            $contextAfter,
+            $registryBefore,
+            $registryAfter,
             $toVerify
         );
 

src/Analyzer/Analyzer.php

@@ -3,15 +3,31 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
-namespace Magento\SemanticVersionChecker\Analyzer;
+namespace Magento\SemanticVersionCheckr\Analyzer;
 
-use Magento\SemanticVersionChecker\DbSchemaReport;
+use Magento\SemanticVersionCheckr\DbSchemaReport;
 use PHPSemVerChecker\Registry\Registry;
 use PHPSemVerChecker\Report\Report;
 
 class Analyzer implements AnalyzerInterface
 {
+
+    /**
+     * @var array|AnalyzerInterface[]
+     */
+    private $analyzers;
+
+    /**
+     * Analyzer constructor.
+     * @param AnalyzerInterface[] $analyzers
+     */
+    public function __construct(array $analyzers)
+    {
+        $this->analyzers = $analyzers;
+    }
+
     /**
      * Compare with a destination registry (what the new source code is like).
      *
@@ -24,15 +40,7 @@ public function analyze($registryBefore, $registryAfter)
         $finalReport = new DbSchemaReport();
 
         /** @var AnalyzerInterface[] */
-        $analyzers = [
-            new ClassAnalyzer(),
-            new InterfaceAnalyzer(),
-            new DbSchemaAnalyzer(),
-            new DbSchemaWhitelistAnalyzer(),
-            new DbSchemaWhitelistReductionAnalyzer()
-        ];
-
-        foreach ($analyzers as $analyzer) {
+        foreach ($this->analyzers as $analyzer) {
             $report = $analyzer->analyze($registryBefore, $registryAfter);
             $finalReport->merge($report);
         }

src/Analyzer/AnalyzerInterface.php

@@ -3,20 +3,26 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
-namespace Magento\SemanticVersionChecker\Analyzer;
+namespace Magento\SemanticVersionCheckr\Analyzer;
 
 use PhpParser\Node\Stmt;
 use PHPSemVerChecker\Registry\Registry;
 use PHPSemVerChecker\Report\Report;
 
+/**
+ * Defines an interface for analyzer.
+ * Analyzer performs comparison of and creates report.
+ */
 interface AnalyzerInterface
 {
     /**
-     * Compare with a destination registry (what the new source code is like).
+     * Compare with a destination registry (what the new source code is like)
      *
      * @param Registry|Stmt $registryBefore
      * @param Registry|Stmt $registryAfter
+     *
      * @return Report
      */
     public function analyze($registryBefore, $registryAfter);

src/Analyzer/ApiMembership/ApiMembershipAnalyzer.php

@@ -3,8 +3,9 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
-namespace Magento\SemanticVersionChecker\Analyzer\ApiMembership;
+namespace Magento\SemanticVersionCheckr\Analyzer\ApiMembership;
 
 use PHPSemVerChecker\Registry\Registry;
 use PHPSemVerChecker\Report\Report;

src/Analyzer/ApiMembership/ApiMembershipAnalyzerTrait.php

@@ -3,8 +3,9 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
-namespace Magento\SemanticVersionChecker\Analyzer\ApiMembership;
+namespace Magento\SemanticVersionCheckr\Analyzer\ApiMembership;
 
 use PhpParser\Node;
 use PHPSemVerChecker\Registry\Registry;
@@ -107,10 +108,11 @@ public function analyzeWithMembership($apiBefore, $apiAfter, $fullBefore, $fullA
      *
      * @param Registry $registryBefore
      * @param Registry $registryAfter
+     *
      * @return void
      * @throws \BadMethodCallException
      */
-    public function analyze($registryBefore, $registryAfter)
+    public function analyze($registryBefore, $registryAfter): void
     {
         throw new \BadMethodCallException('API Membership Analyzers use analyzeWithMembership() instead of analyze()');
     }

src/Analyzer/ApiMembership/ClassApiMembershipAnalyzer.php

@@ -3,10 +3,11 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
-namespace Magento\SemanticVersionChecker\Analyzer\ApiMembership;
+namespace Magento\SemanticVersionCheckr\Analyzer\ApiMembership;
 
-use Magento\SemanticVersionChecker\Analyzer\ClassAnalyzer;
+use Magento\SemanticVersionCheckr\Analyzer\ClassAnalyzer;
 use PHPSemVerChecker\Registry\Registry;
 
 /**

src/Analyzer/ApiMembership/ClassConstantApiMembershipAnalyzer.php

@@ -3,10 +3,11 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
-namespace Magento\SemanticVersionChecker\Analyzer\ApiMembership;
+namespace Magento\SemanticVersionCheckr\Analyzer\ApiMembership;
 
-use Magento\SemanticVersionChecker\Analyzer\ClassConstantAnalyzer;
+use Magento\SemanticVersionCheckr\Analyzer\ClassConstantAnalyzer;
 
 /**
  * Class constant analyzer.

src/Analyzer/ApiMembership/ClassMethodApiMembershipAnalyzer.php

@@ -3,10 +3,11 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
-namespace Magento\SemanticVersionChecker\Analyzer\ApiMembership;
+namespace Magento\SemanticVersionCheckr\Analyzer\ApiMembership;
 
-use Magento\SemanticVersionChecker\Analyzer\ClassMethodAnalyzer;
+use Magento\SemanticVersionCheckr\Analyzer\ClassMethodAnalyzer;
 
 /**
  * Class method analyzer with separate API membership report.

src/Analyzer/ApiMembership/InterfaceApiMembershipAnalyzer.php

@@ -3,10 +3,11 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
-namespace Magento\SemanticVersionChecker\Analyzer\ApiMembership;
+namespace Magento\SemanticVersionCheckr\Analyzer\ApiMembership;
 
-use Magento\SemanticVersionChecker\Analyzer\InterfaceAnalyzer;
+use Magento\SemanticVersionCheckr\Analyzer\InterfaceAnalyzer;
 use PHPSemVerChecker\Registry\Registry;
 
 /**