Skip to content

Commit c3fec73

Browse files
committed
AC-6945::Resolve the pr commentss
1 parent da7a03d commit c3fec73

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

dev/tests/Unit/Console/Command/CompareSourceCommandApiClassesTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,10 @@ public static function changesDataProvider()
5959
$pathToFixtures . '/new-method/source-code-before',
6060
$pathToFixtures . '/new-method/source-code-after',
6161
[
62-
'Class (MINOR)',
62+
'Class (PATCH)',
6363
'Test\Vcs\TestClass::testMethod | [public] Method has been added. | V015'
6464
],
65-
'Minor change is detected.'
65+
'Patch change is detected.'
6666
],
6767
'api-class-removed-class' => [
6868
$pathToFixtures . '/removed-class/source-code-before',
@@ -77,10 +77,10 @@ public static function changesDataProvider()
7777
$pathToFixtures . '/removed-method/source-code-before',
7878
$pathToFixtures . '/removed-method/source-code-after',
7979
[
80-
'Class (MAJOR)',
80+
'Class (PATCH)',
8181
'Test\Vcs\TestClass::testMethod | [public] Method has been removed. | V006'
8282
],
83-
'Major change is detected.'
83+
'Patch change is detected.'
8484
],
8585
'api-class-new-required-method-parameter' => [
8686
$pathToFixtures . '/new-required-method-parameter/source-code-before',

dev/tests/Unit/Console/Command/CompareSourceCommandSystemXmlTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,10 +113,10 @@ public static function changesDataProvider()
113113
$pathToFixtures . '/field-added/source-code-before',
114114
$pathToFixtures . '/field-added/source-code-after',
115115
[
116-
'Suggested semantic versioning change: PATCH',
116+
'Suggested semantic versioning change: MINOR',
117117
'Magento/TestModule/etc/adminhtml/system.xml:0 | magento_testmodule/general/added_field | A field-node was added | M302',
118118
],
119-
'Patch change is detected.',
119+
'Minor change is detected.',
120120
],
121121
'field-removed' => [
122122
$pathToFixtures . '/field-removed/source-code-before',

dev/tests/Unit/Console/Command/HierarchyTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,9 @@ public static function changesDataProvider()
4747
$pathToFixtures . '/public-method-removed-from-non-api-parent-class-extended-by-api-class/source-code-before',
4848
$pathToFixtures . '/public-method-removed-from-non-api-parent-class-extended-by-api-class/source-code-after',
4949
[
50-
'Suggested semantic versioning change: MAJOR',
50+
'Suggested semantic versioning change: PATCH',
5151
],
52-
'Major change is detected.',
52+
'Patch change is detected.',
5353
],
5454
'public-method-removed-from-non-api-trait-used-by-api-class' => [
5555
$pathToFixtures . '/public-method-removed-from-non-api-trait-used-by-api-class/source-code-before',

0 commit comments

Comments
 (0)