Skip to content

Commit cec6352

Browse files
committed
AC-3483:: SVC false-positive: modifying system.xml file from another module
1 parent 4ca87ae commit cec6352

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/Analyzer/SystemXml/Analyzer.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,8 +143,10 @@ private function reportAddedNodesWithDuplicateCheck($afterFile, $addedNodes, $mo
143143
*/
144144
private function isDuplicateNode($node, $existingNode)
145145
{
146+
$nodeData = $node->data;
147+
$existingNodeData = $existingNode->data;
146148
// Remove 'id' key for comparison
147-
unset($node['id'], $existingNode['id']);
149+
unset($nodeData['id'], $existingNodeData['id']);
148150

149151
// Compare the remaining parts of the nodes
150152
return $node == $existingNode;

0 commit comments

Comments
 (0)