AC-14557:: False positives in the backward-incompatible changes report (SVC)

Author: cod62627

src/Analyzer/ClassMethodAnalyzer.php

@@ -20,6 +20,7 @@
 use Magento\SemanticVersionChecker\Operation\ClassMethodOptionalParameterAdded;
 use Magento\SemanticVersionChecker\Operation\ClassMethodOverwriteAdded;
 use Magento\SemanticVersionChecker\Operation\ClassMethodParameterTypingChanged;
+use Magento\SemanticVersionChecker\Operation\ClassMethodParameterTypingChangedNullable;
 use Magento\SemanticVersionChecker\Operation\ClassMethodReturnTypingChanged;
 use Magento\SemanticVersionChecker\Operation\ExtendableClassConstructorOptionalParameterAdded;
 use Magento\SemanticVersionChecker\Operation\Visibility\MethodDecreased as VisibilityMethodDecreased;
@@ -258,17 +259,46 @@ protected function reportChanged($report, $contextBefore, $contextAfter, $method
                     $report->add($this->context, $data);
                     $signatureChanged = true;
                 } elseif ($signatureChanges['parameter_typing_changed']) {
-                    $data = new ClassMethodParameterTypingChanged(
-                        $this->context,
-                        $this->fileAfter,
-                        $contextAfter,
-                        $methodAfter
-                    );
-                    echo "\nTemporary added code \n";
-                    print_r($data);
-                    echo "\n======\n";
-                    print_r($data, true);
-                    echo "\nEnd Temporary added code \n";
+                    $paramsBefore = $methodBefore->params;
+                    $paramsAfter = $methodAfter->params;
+
+                    $isSafeNullableChange = false;
+                    // Check if only difference is added explicit nullable `?` prefix
+                    foreach ($paramsBefore as $index => $paramBefore) {
+                        $paramAfter = $paramsAfter[$index] ?? null;
+                        if (!$paramAfter) {
+                            continue;
+                        }
+
+                        $beforeType = $paramBefore->type;
+                        $afterType = $paramAfter->type;
+
+                        if ($beforeType && $afterType &&
+                            $beforeType instanceof \PhpParser\Node\Name &&
+                            $afterType instanceof \PhpParser\Node\NullableType &&
+                            $afterType->type instanceof \PhpParser\Node\Name &&
+                            $beforeType->toString() === $afterType->type->toString()) {
+                            $isSafeNullableChange = true;
+                        } else {
+                            $isSafeNullableChange = false;
+                            break;
+                        }
+                    }
+                    if ($isSafeNullableChange) {
+                        $data = new ClassMethodParameterTypingChangedNullable(
+                            $this->context,
+                            $this->fileAfter,
+                            $contextAfter,
+                            $methodAfter
+                        );
+                    } else {
+                        $data = new ClassMethodParameterTypingChanged(
+                            $this->context,
+                            $this->fileAfter,
+                            $contextAfter,
+                            $methodAfter
+                        );
+                    }
                     $report->add($this->context, $data);
                     $signatureChanged = true;
                 }

src/Operation/ClassMethodParameterTypingChangedNullable.php

@@ -0,0 +1,54 @@
+<?php
+
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+declare(strict_types=1);
+
+namespace Magento\SemanticVersionChecker\Operation;
+
+use PHPSemVerChecker\Operation\ClassMethodOperationUnary;
+use PHPSemVerChecker\SemanticVersioning\Level;
+
+class ClassMethodParameterTypingChangedNullable extends ClassMethodOperationUnary
+{
+    /**
+     * @var array
+     */
+    protected $code = [
+        'class'     => ['M113', 'M114', 'M115'],
+        'interface' => ['M116'],
+        'trait'     => ['M117', 'M118', 'M119']
+    ];
+
+    /**
+     * @var array
+     */
+    private $mapping = [
+        'M113' => Level::PATCH,
+        'M114' => Level::MAJOR,
+        'M115' => Level::PATCH,
+        'M116' => Level::MAJOR,
+        'M117' => Level::MAJOR,
+        'M118' => Level::MAJOR,
+        'M119' => Level::MAJOR
+    ];
+
+
+    /**
+     * @var string
+     */
+    protected $reason = 'Method parameter typing changed.';
+
+    /**
+     * Returns level of error.
+     *
+     * @return mixed
+     */
+    public function getLevel(): int
+    {
+        return $this->mapping[$this->getCode()];
+    }
+}