MC-36802: SVC doesn't catch MINOR change in PATCH release when adding @api to a class

zakdma · zakdma · commit f2ac0468b2ea · 2020-11-03T12:05:22.000+02:00
diff --git a/src/Helper/Node.php b/src/Helper/Node.php
@@ -32,8 +32,10 @@ public function isApiNode(PhpNode $node)
         if (is_array($comments) && !empty($comments)) {
             foreach ($comments as $comment) {
                 if ($comment instanceof DocComment) {
-                    $result = $result || (strpos($comment->getText(),
-                                SemanticVersionChecker::ANNOTATION_API) !== false);
+                    $result = (strpos($comment->getText(),SemanticVersionChecker::ANNOTATION_API) !== false);
+                    if ($result) {
+                        break;
+                    }
                 }
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -32,8 +32,10 @@ public function isApiNode(PhpNode $node)`
`32`	`32`	`if (is_array($comments) && !empty($comments)) {`
`33`	`33`	`foreach ($comments as $comment) {`
`34`	`34`	`if ($comment instanceof DocComment) {`
`35`		`- $result = $result \|\| (strpos($comment->getText(),`
`36`		`- SemanticVersionChecker::ANNOTATION_API) !== false);`
	`35`	`+ $result = (strpos($comment->getText(),SemanticVersionChecker::ANNOTATION_API) !== false);`
	`36`	`+ if ($result) {`
	`37`	`+ break;`
	`38`	`+ }`
`37`	`39`	`}`
`38`	`40`	`}`
`39`	`41`	`}`