Skip to content

Commit 1c3308d

Browse files
committed
MQE-761: Generation of _failed method with createData action will lead test execution to fatal error
- fix missed unit test and phpDOC
1 parent cbe8670 commit 1c3308d

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

dev/tests/unit/Magento/FunctionalTestFramework/Test/Handlers/TestObjectHandlerTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@ public function testGetTestObject()
5858
[]
5959
);
6060
$expectedFailedActionObject = new ActionObject(
61-
$testDataArrayBuilder->testActionAfterName,
62-
$testDataArrayBuilder->testActionType,
61+
'saveScreenshot',
62+
'saveScreenshot',
6363
[]
6464
);
6565

@@ -95,7 +95,7 @@ public function testGetTestObject()
9595
TestObjectExtractor::TEST_AFTER_HOOK => $expectedAfterHookObject,
9696
TestObjectExtractor::TEST_FAILED_HOOK => $expectedFailedHookObject
9797
],
98-
[]
98+
null
9999
);
100100

101101
$this->assertEquals($expectedTestObject, $actualTestObject);

src/Magento/FunctionalTestingFramework/Test/Util/TestHookObjectExtractor.php

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,16 @@ public function extractHook($parentName, $hookType, $testHook)
5454
return $hook;
5555
}
5656

57+
/**
58+
* Creates the default failed hook object with a single saveScreenshot action.
59+
*
60+
* @param string $parentName
61+
* @return TestHookObject
62+
*/
5763
public function createDefaultFailedHook($parentName)
5864
{
5965

60-
$saveScreenshotStep = ["saveScreenshot" => new ActionObject("saveScreenshot", "saveScreenshot", [])];
66+
$saveScreenshotStep = [new ActionObject("saveScreenshot", "saveScreenshot", [])];
6167

6268
$hook = new TestHookObject(
6369
TestObjectExtractor::TEST_FAILED_HOOK,

src/Magento/FunctionalTestingFramework/Test/Util/TestObjectExtractor.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ public function extractTestData($testData)
9999

100100
// extract failed
101101
$testHooks[self::TEST_FAILED_HOOK] = $this->testHookObjectExtractor->createDefaultFailedHook(
102-
$testData[self::TEST_AFTER_HOOK]
102+
$testData[self::NAME]
103103
);
104104
}
105105

0 commit comments

Comments
 (0)