Skip to content

Commit 596195a

Browse files
committed
MQE-590: Fix PHP Mess Detector Errors
- Enabled line for PHPMD - Codesniffer fixes.
1 parent 3a59e26 commit 596195a

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

bin/static-checks

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,8 @@ vendor/bin/phpcs ./dev/tests/verification --standard=./dev/tests/static/Magento
99
echo "===============================COPY PASTE DETECTOR REPORT==============================="
1010
vendor/bin/phpcpd ./src
1111

12-
# Uncomment lines as part of MQE-590
13-
# echo "===============================PHP MESS DETECTOR REPORT==============================="
14-
# vendor/bin/phpmd ./src text /dev/tests/static/Magento/CodeMessDetector/ruleset.xml --exclude _generated
12+
echo "===============================PHP MESS DETECTOR REPORT==============================="
13+
vendor/bin/phpmd ./src text /dev/tests/static/Magento/CodeMessDetector/ruleset.xml --exclude _generated
1514

1615
echo "===============================MAGENTO COPYRIGHT REPORT==============================="
1716
bin/copyright-check

src/Magento/FunctionalTestingFramework/Test/Objects/ActionObject.php

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -348,8 +348,8 @@ private function findAndReplaceReferences($objectHandler, $inputString)
348348

349349
/**
350350
* Gets the object's dataByName with given $match, differentiating behavior between <array> and <data> nodes.
351-
* @param $obj
352-
* @param $match
351+
* @param string $obj
352+
* @param string $match
353353
* @return string
354354
*/
355355
private function resolveEntityDataObjectReference($obj, $match)
@@ -368,6 +368,13 @@ private function resolveEntityDataObjectReference($obj, $match)
368368
}
369369
}
370370

371+
/**
372+
* Resolves $replacement parameterization with given conditional.
373+
* @param boolean $isParameterized
374+
* @param string $replacement
375+
* @param string $match
376+
* @return string
377+
*/
371378
private function resolveParameterization($isParameterized, $replacement, $match)
372379
{
373380
if ($isParameterized) {

0 commit comments

Comments
 (0)