File tree Expand file tree Collapse file tree 1 file changed +3
-1
lines changed
src/Magento/FunctionalTestingFramework/Suite/Util Expand file tree Collapse file tree 1 file changed +3
-1
lines changed Original file line number Diff line number Diff line change @@ -65,7 +65,7 @@ public function parseSuiteDataIntoObjects($parsedSuiteData)
65
65
// skip non array items parsed from suite (suite objects will always be arrays)
66
66
continue ;
67
67
}
68
- //check for collisions between suite and existing group names
68
+
69
69
$ this ->validateSuiteName ($ parsedSuite );
70
70
71
71
//extract include and exclude references
@@ -115,12 +115,14 @@ public function parseSuiteDataIntoObjects($parsedSuiteData)
115
115
*/
116
116
private function validateSuiteName ($ parsedSuite )
117
117
{
118
+ //check if name used is using special char or the "default" reserved name
118
119
NameValidationUtil::validateName ($ parsedSuite [self ::NAME ], 'Suite ' );
119
120
if ($ parsedSuite [self ::NAME ] == 'default ' ) {
120
121
throw new XmlException ("A Suite can not have the name \"default \"" );
121
122
}
122
123
123
124
$ suiteName = $ parsedSuite [self ::NAME ];
125
+ //check for collisions between suite and existing group names
124
126
$ testGroupConflicts = TestObjectHandler::getInstance ()->getTestsByGroup ($ suiteName );
125
127
if (!empty ($ testGroupConflicts )) {
126
128
$ testGroupConflictsFileNames = "" ;
You can’t perform that action at this time.
0 commit comments