Skip to content

Commit a7121eb

Browse files
committed
MQE-347: Use a remove tag instead of a remove attribute
- removing reference to remove attribute
1 parent eba01db commit a7121eb

File tree

2 files changed

+1
-153
lines changed

2 files changed

+1
-153
lines changed

src/Magento/FunctionalTestingFramework/Test/Config/Converter/Dom/Flat.php

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -73,15 +73,7 @@ public function convertXml(\DOMNode $source, $basePath = '')
7373
$value = [];
7474
/** @var \DOMNode $node */
7575
foreach ($source->childNodes as $node) {
76-
// TODO Remove this block once the 'remove' attribute has been full deprecated
77-
if ($node->nodeType == XML_ELEMENT_NODE && $node->getAttribute('remove') != null) {
78-
trigger_error(
79-
"use of the 'remove' attribute will be deprecated in the next release.",
80-
E_USER_DEPRECATED
81-
);
82-
}
83-
84-
if ($node->nodeType == XML_ELEMENT_NODE && $node->getAttribute('remove') != 'true') {
76+
if ($node->nodeType == XML_ELEMENT_NODE) {
8577
$nodeName = $node->nodeName;
8678
$nodePath = $basePath . '/' . $nodeName;
8779
$arrayKeyAttribute = $this->arrayNodeConfig->getAssocArrayKeyAttribute($nodePath);

0 commit comments

Comments
 (0)