MQE-148: Add Code Sniffer static test to Acceptance Test Framework & Tests projects and run it in Jenkins

- fix cp detector

Author: okolesnyk

src/Magento/AcceptanceTestFramework/Config/Converter/Dom/Flat.php

@@ -29,6 +29,25 @@ public function __construct(ArrayNodeConfig $arrayNodeConfig)
         $this->arrayNodeConfig = $arrayNodeConfig;
     }
 
+    /**
+     * Retrieve key-value pairs of node attributes
+     *
+     * @param \DOMNode $node
+     * @return array
+     */
+    protected function getNodeAttributes(\DOMNode $node)
+    {
+        $result = [];
+        $attributes = $node->attributes ?: [];
+        /** @var \DOMNode $attribute */
+        foreach ($attributes as $attribute) {
+            if ($attribute->nodeType == XML_ATTRIBUTE_NODE) {
+                $result[$attribute->nodeName] = $attribute->nodeValue;
+            }
+        }
+        return $result;
+    }
+
     /**
      * Convert dom node tree to array in general case or to string in a case of a text node
      *
@@ -109,23 +128,4 @@ public function convert(\DOMNode $source, $basePath = '')
         }
         return $result;
     }
-
-    /**
-     * Retrieve key-value pairs of node attributes
-     *
-     * @param \DOMNode $node
-     * @return array
-     */
-    protected function getNodeAttributes(\DOMNode $node)
-    {
-        $result = [];
-        $attributes = $node->attributes ?: [];
-        /** @var \DOMNode $attribute */
-        foreach ($attributes as $attribute) {
-            if ($attribute->nodeType == XML_ATTRIBUTE_NODE) {
-                $result[$attribute->nodeName] = $attribute->nodeValue;
-            }
-        }
-        return $result;
-    }
 }

src/Magento/AcceptanceTestFramework/ObjectManager/Factory.php

@@ -224,10 +224,10 @@ protected function parseArray(&$array)
      */
     public function create($requestedType, array $arguments = [])
     {
-        $type = $this->config->getInstanceType($requestedType);
-        $parameters = $this->definitions->getParameters($type);
+        $instanceType = $this->config->getInstanceType($requestedType);
+        $parameters = $this->definitions->getParameters($instanceType);
         if ($parameters == null) {
-            return new $type();
+            return new $instanceType();
         }
         if (isset($this->creationStack[$requestedType])) {
             $lastFound = end($this->creationStack);
@@ -243,7 +243,7 @@ public function create($requestedType, array $arguments = [])
             throw $e;
         }
 
-        $reflection = new \ReflectionClass($type);
+        $reflection = new \ReflectionClass($instanceType);
 
         return $reflection->newInstanceArgs($args);
     }

src/Magento/AcceptanceTestFramework/ObjectManager/Factory/Dynamic/Developer.php

@@ -172,6 +172,7 @@ protected function parseArray(&$array)
      * @throws \Exception
      *
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
+     * @SuppressWarnings(PHPCPD)
      */
     public function create($requestedType, array $arguments = [])
     {