Skip to content

Commit b4bdf77

Browse files
committed
MQE-1068: Require Issue ID for Skipped Test
- Moved deprecation warning
1 parent f7cb05e commit b4bdf77

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

src/Magento/FunctionalTestingFramework/Test/Objects/TestObject.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,6 @@ public function isSkipped()
130130
if (array_key_exists('skip', $this->annotations)) {
131131
return true;
132132
} elseif (array_key_exists('group', $this->annotations) && (in_array("skip", $this->annotations['group']))) {
133-
print("Use of group skip will be deprecated in MFTF 3.0.0. Please update tests to use skip tags.");
134133
return true;
135134
}
136135
return false;

src/Magento/FunctionalTestingFramework/Test/Util/AnnotationExtractor.php

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,14 +62,25 @@ public function extractAnnotations($testAnnotations, $filename)
6262
);
6363
continue;
6464
}
65+
6566
if ($annotationKey == "skip") {
6667
$annotationData = $annotationData['issueId'];
6768
$this->validateSkippedIssues($annotationData, $filename);
6869
}
70+
6971
foreach ($annotationData as $annotationValue) {
7072
$annotationValues[] = $annotationValue[self::ANNOTATION_VALUE];
7173
}
7274

75+
if ($annotationKey == "group" && in_array("skip", $annotationValues)) {
76+
print(
77+
"Test: $filename" .
78+
PHP_EOL .
79+
"Use of group skip will be deprecated in MFTF 3.0.0. Please update tests to use skip tags." .
80+
PHP_EOL
81+
);
82+
}
83+
7384
$annotationObjects[$annotationKey] = $annotationValues;
7485
}
7586
$this->addStoryTitleToMap($annotationObjects, $filename);

0 commit comments

Comments
 (0)