Amend PHPUnit tests and Static tests

Author: lbajsarowicz

dev/tests/unit/Magento/FunctionalTestFramework/Test/Objects/ActionObjectTest.php

@@ -227,7 +227,7 @@ public function testResolveUrl()
     }
 
     /**
-     * {{PageObject}} should not be replaced and should elicit a warning in console
+     * {{PageObject}} should not be replaced and should throw an exception!
      *
      * @throws /Exception
      */
@@ -248,18 +248,9 @@ public function testResolveUrlWithNoAttribute()
         // Call the method under test
         $actionObject->resolveReferences();
 
-        // Expect this warning to get generated
-        TestLoggingUtil::getInstance()->validateMockLogStatement(
-            "warning",
-            "page url attribute not found and is required",
-            ['action' => $actionObject->getType(), 'url' => '{{PageObject}}', 'stepKey' => $actionObject->getStepKey()]
-        );
+        $this->expectExceptionMessage('Can not resolve replacements: "{{PageObject}}"');
 
-        // Verify
-        $expected = [
-            'url' => '{{PageObject}}'
-        ];
-        $this->assertEquals($expected, $actionObject->getCustomActionAttributes());
+        $actionObject->getCustomActionAttributes();
     }
 
     /**

src/Magento/FunctionalTestingFramework/Test/Objects/ActionObject.php

@@ -428,15 +428,17 @@ private function resolveUrlReference()
     /**
      * Returns array of missing references
      *
-     * @param $replacement
+     * @param string $replacement
      * @return array
      */
     private function getMissingReferences($replacement): array
     {
         $mustachePattern = '/({{[\w]+}})|({{[\w]+\.[\w\[\]]+}})|({{[\w]+\.[\w]+\((?(?!}}).)+\)}})/';
         preg_match_all($mustachePattern, $replacement, $matches);
 
-        return array_filter($matches[1], function($match) { return false === strpos($match, '_ENV.'); });
+        return array_filter($matches[1], function ($match) {
+            return false === strpos($match, '_ENV.');
+        });
     }
 
     /**