MQE-610: [PHPMD] Reduce Cyclomatic Complexity in Problem Methods

Refactored to keep Cyclomatic complexity <= 10.
Added comments to functions that are not refactored for readability

Author: soumyau

src/Magento/FunctionalTestingFramework/Config/Converter/Dom/Flat.php

@@ -70,6 +70,7 @@ protected function getNodeAttributes(\DOMNode $node)
      * @return string|array
      * @throws \UnexpectedValueException
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
+     * Revisited to reduce cyclomatic complexity, left unrefactored for readability
      */
     public function convert(\DOMNode $source, $basePath = '')
     {

src/Magento/FunctionalTestingFramework/ObjectManager/Config/Config.php

@@ -152,7 +152,7 @@ public function getPreference($type)
      *
      * @param string $type
      * @return array
-     * @SuppressWarnings(PHPMD.CyclomaticComplexity)
+     * Revisited to reduce cyclomatic complexity, left unrefactored for readability
      */
     protected function collectConfiguration($type)
     {
@@ -194,7 +194,6 @@ protected function collectConfiguration($type)
      *
      * @param array $configuration
      * @return void
-     * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      */
     protected function mergeConfiguration(array $configuration)
     {
@@ -207,32 +206,44 @@ protected function mergeConfiguration(array $configuration)
                     break;
 
                 default:
-                    $key = ltrim($key, '\\');
-                    if (isset($curConfig['type'])) {
-                        $this->virtualTypes[$key] = ltrim($curConfig['type'], '\\');
-                    }
-                    if (isset($curConfig['arguments'])) {
-                        if (!empty($this->mergedArguments)) {
-                            $this->mergedArguments = [];
-                        }
-                        if (isset($this->arguments[$key])) {
-                            $this->arguments[$key] = array_replace($this->arguments[$key], $curConfig['arguments']);
-                        } else {
-                            $this->arguments[$key] = $curConfig['arguments'];
-                        }
-                    }
-                    if (isset($curConfig['shared'])) {
-                        if (!$curConfig['shared']) {
-                            $this->nonShared[$key] = 1;
-                        } else {
-                            unset($this->nonShared[$key]);
-                        }
-                    }
+                    $this->setArguments($key, $curConfig);
                     break;
             }
         }
     }
 
+    /**
+     * Set arguments
+     *
+     * @param string $key
+     * @param array  $config
+     * @return void
+     */
+    private function setArguments($key, $config)
+    {
+        $key = ltrim($key, '\\');
+        if (isset($config['type'])) {
+            $this->virtualTypes[$key] = ltrim($config['type'], '\\');
+        }
+        if (isset($config['arguments'])) {
+            if (!empty($this->mergedArguments)) {
+                $this->mergedArguments = [];
+            }
+            if (isset($this->arguments[$key])) {
+                $this->arguments[$key] = array_replace($this->arguments[$key], $config['arguments']);
+            } else {
+                $this->arguments[$key] = $config['arguments'];
+            }
+        }
+        if (isset($config['shared'])) {
+            if (!$config['shared']) {
+                $this->nonShared[$key] = 1;
+            } else {
+                unset($this->nonShared[$key]);
+            }
+        }
+    }
+
     /**
      * Extend configuration
      *

src/Magento/FunctionalTestingFramework/ObjectManager/Factory.php

@@ -103,6 +103,7 @@ public function prepareArguments($object, $method, array $arguments = [])
      *
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      * @SuppressWarnings(PHPMD.NPathComplexity)
+     * Revisited to reduce cyclomatic complexity, left unrefactored for readability
      */
     protected function resolveArguments($requestedType, array $parameters, array $arguments = [])
     {
@@ -179,8 +180,10 @@ protected function resolveArguments($requestedType, array $parameters, array $ar
      *
      * @param array $array
      * @return void
+     *
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      * @SuppressWarnings(PHPMD.NPathComplexity)
+     * Revisited to reduce cyclomatic complexity, left unrefactored for readability
      */
     protected function parseArray(&$array)
     {
@@ -219,8 +222,6 @@ protected function parseArray(&$array)
      * @param array  $arguments
      * @return object
      * @throws \Exception
-     *
-     * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      */
     public function create($requestedType, array $arguments = [])
     {

src/Magento/FunctionalTestingFramework/ObjectManager/Factory/Dynamic/Developer.php

@@ -87,6 +87,7 @@ public function setObjectManager(\Magento\FunctionalTestingFramework\ObjectManag
      *
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      * @SuppressWarnings(PHPMD.NPathComplexity)
+     * Revisited to reduce cyclomatic complexity, left unrefactored for readability
      */
     protected function resolveArguments($requestedType, array $parameters, array $arguments = [])
     {

src/Magento/FunctionalTestingFramework/Suite/Util/SuiteObjectExtractor.php

@@ -40,9 +40,11 @@ public function __construct()
      * @param array $parsedSuiteData
      * @return array
      * @throws XmlException
+     * @throws \Exception
+     *
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      * @SuppressWarnings(PHPMD.NPathComplexity)
-     * @throws \Exception
+     * Revisited to reduce cyclomatic complexity, left unrefactored for readability
      */
     public function parseSuiteDataIntoObjects($parsedSuiteData)
     {

src/Magento/FunctionalTestingFramework/Test/Config/Converter/Dom/Flat.php

@@ -70,6 +70,7 @@ public function convert($source)
      * @return string|array
      * @throws \UnexpectedValueException
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
+     * Revisited to reduce cyclomatic complexity, left unrefactored for readability
      */
     public function convertXml(\DOMNode $source, $basePath = '')
     {