Skip to content

Commit 03aac8b

Browse files
committed
MC-2365: Create MFTF tests for vertical alignment of rows
- rename min height data in existing tests
1 parent 77127a0 commit 03aac8b

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Data/CommonContentTypeData.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
<data key="fieldName">min_height</data>
2828
<data key="value">300</data>
2929
</entity>
30-
<entity name="PageBuilderAppearanceMinHeightProperty_200" type="pagebuilder_min_height_property">
30+
<entity name="PageBuilderMinHeightProperty_200" type="pagebuilder_min_height_property">
3131
<data key="name">Minimum Height</data>
3232
<data key="section">layout</data>
3333
<data key="fieldName">min_height</data>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderColumnContentTest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,12 +153,12 @@
153153
<argument name="contentType" value="PageBuilderColumnContentType"/>
154154
</actionGroup>
155155
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty">
156-
<argument name="property" value="PageBuilderAppearanceMinHeightProperty_200"/>
156+
<argument name="property" value="PageBuilderMinHeightProperty_200"/>
157157
</actionGroup>
158158
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
159159
<comment userInput="Validate Column Height On Stage With Custom Min Height Matches Expected" stepKey="commentValidateColumnHeight"/>
160160
<executeJS function="{{PageBuilderStage.computedHeightOnStage(PageBuilderColumnContentType.role,'1')}}" stepKey="actualStageContentTypeHeight"/>
161-
<executeJS function="return Math.round({{PageBuilderAppearanceMinHeightProperty_200.value}} + {{PageBuilderPaddingProperty10.paddingTop}} + {{PageBuilderPaddingProperty10.paddingBottom}})" stepKey="expectedColumnHeight"/>
161+
<executeJS function="return Math.round({{PageBuilderMinHeightProperty_200.value}} + {{PageBuilderPaddingProperty10.paddingTop}} + {{PageBuilderPaddingProperty10.paddingBottom}})" stepKey="expectedColumnHeight"/>
162162
<assertEquals stepKey="assertHeightOnStageMatchesExpected">
163163
<expectedResult type="variable">actualStageContentTypeHeight</expectedResult>
164164
<actualResult type="variable">expectedColumnHeight</actualResult>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderColumnTest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -396,7 +396,7 @@
396396
<argument name="property" value="PageBuilderColumnAppearanceProperty_Bottom"/>
397397
</actionGroup>
398398
<actionGroup ref="fillSlideOutPanelField" stepKey="enterMinHeightProperty200">
399-
<argument name="property" value="PageBuilderAppearanceMinHeightProperty_200"/>
399+
<argument name="property" value="PageBuilderMinHeightProperty_200"/>
400400
</actionGroup>
401401
<actionGroup ref="chooseVisualSelectOption" stepKey="enterVerticalAlignmenBottomProperty">
402402
<argument name="property" value="PageBuilderVerticalAlignmentPropertyBottom"/>
@@ -966,7 +966,7 @@
966966
<argument name="contentTypeIndex" value="3"/>
967967
</actionGroup>
968968
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty3">
969-
<argument name="property" value="PageBuilderAppearanceMinHeightProperty_200"/>
969+
<argument name="property" value="PageBuilderMinHeightProperty_200"/>
970970
</actionGroup>
971971
<comment userInput="I fill out color into Background Color using Color Picker" stepKey="comment"/>
972972
<actionGroup ref="fillOutColorPicker" stepKey="fillOutColor">

0 commit comments

Comments
 (0)