Skip to content

Commit 04275e5

Browse files
danmooney2danmooney2
committed
MC-3934: Slide/Banner Overlay & Button Do Not Show On Storefront When Set To On Hover
Extend BannerCollage*OverlayOnHover on tests from BannerPosterOverlayOnHover
1 parent 1e3724e commit 04275e5

File tree

3 files changed

+12
-192
lines changed

3 files changed

+12
-192
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageCenterAppearanceTest.xml

Lines changed: 4 additions & 64 deletions
Original file line numberDiff line numberDiff line change
@@ -528,7 +528,7 @@
528528
<moveMouseOver selector="{{BannerOnFrontend.base('1')}}" stepKey="moveMouseOverBannerStorefrontMobile"/>
529529
<seeElement selector="{{BannerOnFrontend.mobileTransparentOverlay('1')}}" stepKey="seeTransparentOverlayOnHoverStorefrontMobile"/>
530530
</test>
531-
<test name="BannerCollageCenterOverlayOnHover">
531+
<test name="BannerCollageCenterOverlayOnHover" extends="BannerPosterOverlayOnHover">
532532
<annotations>
533533
<features value="PageBuilder"/>
534534
<stories value="Banner"/>
@@ -541,73 +541,13 @@
541541
<group value="pagebuilder-banner"/>
542542
<group value="pagebuilder-bannerCollageCenter"/>
543543
</annotations>
544-
<before>
545-
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
546-
<actionGroup ref="navigateToAPageWithPageBuilder" stepKey="navigateToAPageWithPageBuilder"/>
547-
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
548-
</before>
549-
<after>
550-
<resizeWindow width="1280" height="1024" stepKey="resizeWindowToDesktop"/>
551-
<actionGroup ref="logout" stepKey="logout"/>
552-
</after>
553-
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
554-
<argument name="contentType" value="PageBuilderBannerContentType"/>
555-
</actionGroup>
556-
<actionGroup ref="expandPageBuilderPanelGroup" stepKey="expandPageBuilderPanelGroup">
557-
<argument name="group" value="PageBuilderBannerContentType"/>
558-
</actionGroup>
559-
<actionGroup ref="dragContentTypeToStage" stepKey="dragBannerIntoStage">
560-
<argument name="contentType" value="PageBuilderBannerContentType"/>
561-
</actionGroup>
562-
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage">
563-
<argument name="contentType" value="PageBuilderBannerContentType"/>
564-
</actionGroup>
565-
<!-- Fill Out Edit Panel -->
566-
<comment userInput="Fill Out Edit Panel" stepKey="commentFillEditPanel"/>
567544
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
568545
<argument name="property" value="PageBuilderBannerCollageCenteredProperty"/>
569546
</actionGroup>
570-
<actionGroup ref="fillSlideOutPanelField" stepKey="enterBackgroundColor">
571-
<argument name="property" value="PageBuilderBackgroundColor_Plaintext_Green"/>
572-
</actionGroup>
573-
<actionGroup ref="selectSlideOutPanelField" stepKey="enterBannerOverlayShowOnHover">
574-
<argument name="property" value="PageBuilderBannerShowContentOverlayOnHoverProperty"/>
575-
</actionGroup>
576-
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterBannerOverlayColor">
577-
<argument name="property" value="PageBuilderBannerContentOverlayColorProperty"/>
578-
</actionGroup>
579-
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterBannerOverlayTransparency">
580-
<argument name="property" value="PageBuilderBannerOverlayTransparencyProperty"/>
581-
</actionGroup>
582-
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
583-
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusEditor"/>
584-
<!-- Validate Stage -->
585-
<comment userInput="Validate Stage" stepKey="commentValidateStage"/>
586-
<seeElement selector="{{BannerOnBackend.appearance('1', PageBuilderBannerCollageCenteredProperty.value)}}" stepKey="seeCollageCenteredStage"/>
587-
<seeElement selector="{{BannerOnBackend.backgroundColor('1', PageBuilderBackgroundColor_Plaintext_Green.rgb)}}" stepKey="seeBackgroundColorStage"/>
588-
<seeElement selector="{{BannerOnBackend.transparentOverlay('1')}}" stepKey="seeTransparentOverlayStage"/>
547+
<seeElement selector="{{BannerOnBackend.appearance('1', PageBuilderBannerCollageCenteredProperty.value)}}" stepKey="seeAppearanceStage"/>
589548
<moveMouseOver selector="{{BannerOnBackend.appearance('1', PageBuilderBannerCollageCenteredProperty.value)}}" stepKey="moveMouseOverBannerStage"/>
590-
<seeElement selector="{{BannerOnBackend.overlayColorAndTransparency('1', PageBuilderBannerContentOverlayColorProperty.rgb, PageBuilderBannerOverlayTransparencyProperty.decimal)}}" stepKey="seeOverlayOnHoverStage"/>
591-
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage"/>
592-
<!-- Validate Storefront -->
593-
<comment userInput="Validate Storefront" stepKey="commentValidateStorefront"/>
594-
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
595-
<argument name="contentType" value="PageBuilderBannerContentType"/>
596-
</actionGroup>
597-
<seeElement selector="{{BannerOnFrontend.appearance('1', PageBuilderBannerCollageCenteredProperty.value)}}" stepKey="seeCollageCenteredStorefront"/>
598-
<seeElement selector="{{BannerOnFrontend.backgroundColor('1', PageBuilderBackgroundColor_Plaintext_Green.rgb)}}" stepKey="seeBackgroundColorStorefront"/>
599-
<seeElement selector="{{BannerOnFrontend.transparentOverlay('1')}}" stepKey="seeTransparentOverlayStorefront"/>
600-
<moveMouseOver selector="{{BannerOnFrontend.base('1')}}" stepKey="moveMouseOverBannerStorefront"/>
601-
<seeElement selector="{{BannerOnFrontend.overlayColorAndTransparency('1', PageBuilderBannerContentOverlayColorProperty.rgb, PageBuilderBannerOverlayTransparencyProperty.decimal)}}" stepKey="seeOverlayOnHoverStorefront"/>
602-
<moveMouseOver selector="{{BannerOnFrontend.base('1')}}" x="-1" y="0" stepKey="moveMouseAwayFromBanner"/>
603-
<!-- Validate Storefront Mobile -->
604-
<comment userInput="Validate Storefront Mobile" stepKey="commentValidateStorefrontMobile"/>
605-
<resizeWindow width="767" height="1000" stepKey="resizeWindowToMobile"/>
606-
<seeElement selector="{{BannerOnFrontend.appearance('1', PageBuilderBannerCollageCenteredProperty.value)}}" stepKey="seeCollageCenteredStorefrontMobile"/>
607-
<seeElement selector="{{BannerOnFrontend.mobileBackgroundColor('1', PageBuilderBackgroundColor_Plaintext_Green.rgb)}}" stepKey="seeBackgroundColorStorefrontMobile"/>
608-
<seeElement selector="{{BannerOnFrontend.mobileTransparentOverlay('1')}}" stepKey="seeTransparentOverlayStorefrontMobile"/>
609-
<moveMouseOver selector="{{BannerOnFrontend.base('1')}}" stepKey="moveMouseOverBannerStorefrontMobile"/>
610-
<seeElement selector="{{BannerOnFrontend.mobileOverlayColorAndTransparency('1', PageBuilderBannerContentOverlayColorProperty.rgb, PageBuilderBannerOverlayTransparencyProperty.decimal)}}" stepKey="seeOverlayOnHoverStorefrontMobile"/>
549+
<seeElement selector="{{BannerOnFrontend.appearance('1', PageBuilderBannerCollageCenteredProperty.value)}}" stepKey="seeAppearanceStorefront"/>
550+
<seeElement selector="{{BannerOnFrontend.appearance('1', PageBuilderBannerCollageCenteredProperty.value)}}" stepKey="seeAppearanceStorefrontMobile"/>
611551
</test>
612552
<test name="BannerCollageCenterOverlayAndButtonOnHover">
613553
<annotations>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageLeftAppearanceTest.xml

Lines changed: 4 additions & 64 deletions
Original file line numberDiff line numberDiff line change
@@ -528,7 +528,7 @@
528528
<moveMouseOver selector="{{BannerOnFrontend.base('1')}}" stepKey="moveMouseOverBannerStorefrontMobile"/>
529529
<seeElement selector="{{BannerOnFrontend.mobileTransparentOverlay('1')}}" stepKey="seeTransparentOverlayOnHoverStorefrontMobile"/>
530530
</test>
531-
<test name="BannerCollageLeftOverlayOnHover">
531+
<test name="BannerCollageLeftOverlayOnHover" extends="BannerPosterOverlayOnHover">
532532
<annotations>
533533
<features value="PageBuilder"/>
534534
<stories value="Banner"/>
@@ -541,73 +541,13 @@
541541
<group value="pagebuilder-banner"/>
542542
<group value="pagebuilder-bannerCollageLeft"/>
543543
</annotations>
544-
<before>
545-
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
546-
<actionGroup ref="navigateToAPageWithPageBuilder" stepKey="navigateToAPageWithPageBuilder"/>
547-
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
548-
</before>
549-
<after>
550-
<resizeWindow width="1280" height="1024" stepKey="resizeWindowToDesktop"/>
551-
<actionGroup ref="logout" stepKey="logout"/>
552-
</after>
553-
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
554-
<argument name="contentType" value="PageBuilderBannerContentType"/>
555-
</actionGroup>
556-
<actionGroup ref="expandPageBuilderPanelGroup" stepKey="expandPageBuilderPanelGroup">
557-
<argument name="group" value="PageBuilderBannerContentType"/>
558-
</actionGroup>
559-
<actionGroup ref="dragContentTypeToStage" stepKey="dragBannerIntoStage">
560-
<argument name="contentType" value="PageBuilderBannerContentType"/>
561-
</actionGroup>
562-
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage">
563-
<argument name="contentType" value="PageBuilderBannerContentType"/>
564-
</actionGroup>
565-
<!-- Fill Out Edit Panel -->
566-
<comment userInput="Fill Out Edit Panel" stepKey="commentFillEditPanel"/>
567544
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
568545
<argument name="property" value="PageBuilderBannerCollageLeftProperty"/>
569546
</actionGroup>
570-
<actionGroup ref="fillSlideOutPanelField" stepKey="enterBackgroundColor">
571-
<argument name="property" value="PageBuilderBackgroundColor_Plaintext_Green"/>
572-
</actionGroup>
573-
<actionGroup ref="selectSlideOutPanelField" stepKey="enterBannerOverlayShowOnHover">
574-
<argument name="property" value="PageBuilderBannerShowContentOverlayOnHoverProperty"/>
575-
</actionGroup>
576-
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterBannerOverlayColor">
577-
<argument name="property" value="PageBuilderBannerContentOverlayColorProperty"/>
578-
</actionGroup>
579-
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterBannerOverlayTransparency">
580-
<argument name="property" value="PageBuilderBannerOverlayTransparencyProperty"/>
581-
</actionGroup>
582-
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
583-
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusEditor"/>
584-
<!-- Validate Stage -->
585-
<comment userInput="Validate Stage" stepKey="commentValidateStage"/>
586-
<seeElement selector="{{BannerOnBackend.appearance('1', PageBuilderBannerCollageLeftProperty.value)}}" stepKey="seeCollageLeftStage"/>
587-
<seeElement selector="{{BannerOnBackend.backgroundColor('1', PageBuilderBackgroundColor_Plaintext_Green.rgb)}}" stepKey="seeBackgroundColorStage"/>
588-
<seeElement selector="{{BannerOnBackend.transparentOverlay('1')}}" stepKey="seeTransparentOverlayStage"/>
547+
<seeElement selector="{{BannerOnBackend.appearance('1', PageBuilderBannerCollageLeftProperty.value)}}" stepKey="seeAppearanceStage"/>
589548
<moveMouseOver selector="{{BannerOnBackend.appearance('1', PageBuilderBannerCollageLeftProperty.value)}}" stepKey="moveMouseOverBannerStage"/>
590-
<seeElement selector="{{BannerOnBackend.overlayColorAndTransparency('1', PageBuilderBannerContentOverlayColorProperty.rgb, PageBuilderBannerOverlayTransparencyProperty.decimal)}}" stepKey="seeOverlayOnHoverStage"/>
591-
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage"/>
592-
<!-- Validate Storefront -->
593-
<comment userInput="Validate Storefront" stepKey="commentValidateStorefront"/>
594-
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
595-
<argument name="contentType" value="PageBuilderBannerContentType"/>
596-
</actionGroup>
597-
<seeElement selector="{{BannerOnFrontend.appearance('1', PageBuilderBannerCollageLeftProperty.value)}}" stepKey="seeCollageLeftStorefront"/>
598-
<seeElement selector="{{BannerOnFrontend.backgroundColor('1', PageBuilderBackgroundColor_Plaintext_Green.rgb)}}" stepKey="seeBackgroundColorStorefront"/>
599-
<seeElement selector="{{BannerOnFrontend.transparentOverlay('1')}}" stepKey="seeTransparentOverlayStorefront"/>
600-
<moveMouseOver selector="{{BannerOnFrontend.base('1')}}" stepKey="moveMouseOverBannerStorefront"/>
601-
<seeElement selector="{{BannerOnFrontend.overlayColorAndTransparency('1', PageBuilderBannerContentOverlayColorProperty.rgb, PageBuilderBannerOverlayTransparencyProperty.decimal)}}" stepKey="seeOverlayOnHoverStorefront"/>
602-
<moveMouseOver selector="{{BannerOnFrontend.base('1')}}" x="-1" y="0" stepKey="moveMouseAwayFromBanner"/>
603-
<!-- Validate Storefront Mobile -->
604-
<comment userInput="Validate Storefront Mobile" stepKey="commentValidateStorefrontMobile"/>
605-
<resizeWindow width="767" height="1000" stepKey="resizeWindowToMobile"/>
606-
<seeElement selector="{{BannerOnFrontend.appearance('1', PageBuilderBannerCollageLeftProperty.value)}}" stepKey="seeCollageLeftStorefrontMobile"/>
607-
<seeElement selector="{{BannerOnFrontend.mobileBackgroundColor('1', PageBuilderBackgroundColor_Plaintext_Green.rgb)}}" stepKey="seeBackgroundColorStorefrontMobile"/>
608-
<seeElement selector="{{BannerOnFrontend.mobileTransparentOverlay('1')}}" stepKey="seeTransparentOverlayStorefrontMobile"/>
609-
<moveMouseOver selector="{{BannerOnFrontend.base('1')}}" stepKey="moveMouseOverBannerStorefrontMobile"/>
610-
<seeElement selector="{{BannerOnFrontend.mobileOverlayColorAndTransparency('1', PageBuilderBannerContentOverlayColorProperty.rgb, PageBuilderBannerOverlayTransparencyProperty.decimal)}}" stepKey="seeOverlayOnHoverStorefrontMobile"/>
549+
<seeElement selector="{{BannerOnFrontend.appearance('1', PageBuilderBannerCollageLeftProperty.value)}}" stepKey="seeAppearanceStorefront"/>
550+
<seeElement selector="{{BannerOnFrontend.appearance('1', PageBuilderBannerCollageLeftProperty.value)}}" stepKey="seeAppearanceStorefrontMobile"/>
611551
</test>
612552
<test name="BannerCollageLeftOverlayAndButtonOnHover">
613553
<annotations>

0 commit comments

Comments
 (0)