Skip to content

Commit 1106050

Browse files
committed
MC-3228: Add Missing P0-P1 MFTF Tests For Slider
- Adding test for slider default settings section - Removing slideWrapper selector - Updating slider data
1 parent 8d39017 commit 1106050

File tree

5 files changed

+114
-23
lines changed

5 files changed

+114
-23
lines changed

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeSliderActionGroup.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
</arguments>
1515
<comment userInput="Adding Slide" stepKey="comment"/>
1616
<executeJS function="return document.getElementsByClassName('pagebuilder-slide').length+1" stepKey="initialNumberOfSlidesPlusOne"/>
17-
<click selector="{{SlideOnBackend.slideWrapper}}" stepKey="focusOnSlider"/>
17+
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusSlide"/>
1818
<moveMouseOver selector="{{PageBuilderStage.contentTypeInStageByIndex(PageBuilderSliderContentType.role, slideGroupIndex)}}" stepKey="mouseOverSlider"/>
1919
<waitForPageLoad stepKey="waitForPageLoad1"/>
2020
<waitForElementVisible selector="{{PageBuilderContentTypeOptionsMenu.contentTypeOptionsMenu(PageBuilderSliderContentType.role)}}" stepKey="waitForOptionsMenu"/>

app/code/Magento/PageBuilder/Test/Mftf/Data/SliderData.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
<data key="value">false</data>
5555
</entity>
5656
<!-- Infinite Loop -->
57-
<entity name="PageBuilderSliderInfinite_Enabled" type="pagebuilder_slider_infinite_loop_property">
57+
<entity name="PageBuilderSliderInfiniteLoop_Enabled" type="pagebuilder_slider_infinite_loop_property">
5858
<data key="name">Is Infinite</data>
5959
<data key="section">settings</data>
6060
<data key="fieldName">is_infinite</data>

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderSliderSection.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,6 @@
132132
</section>
133133
<section name="SlideOnBackend">
134134
<element name="all" type="button" selector=".pagebuilder-slide"/>
135-
<element name="slideWrapper" type="button" selector=".pagebuilder-slide-wrapper"/>
136135
<element name="base" type="text" selector="(//div[@data-role='slide'])[{{arg1}}]" parameterized="true"/>
137136
<element name="emptySlide" type="button" selector="(//div[@data-role='slide'])[{{arg1}}]//div[@data-element='content'][contains(@class,'pagebuilder-empty-slide') and text()='Edit Slide Text']" parameterized="true"/>
138137
<element name="editableButtonItemElement" type="button" selector="(//div[@data-role='slide'])[{{arg1}}]//a[@data-element='button']//span[contains(@contenteditable, 'true')]" parameterized="true"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemCommonTest.xml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1013,7 +1013,7 @@
10131013
</actionGroup>
10141014
<actionGroup ref="closeEditPanelSettings" stepKey="closeEditPanelSettings"/>
10151015
<!--Verify there are 2 buttons when hovering-->
1016-
<click selector="{{SlideOnBackend.slideWrapper}}" stepKey="clickSliderInStage1"/>
1016+
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusSlide"/>
10171017
<comment userInput="Verify there are 2 buttons when hovering" stepKey="commentVerifyButtons" />
10181018
<actionGroup ref="verifyUploadImageButtons" stepKey="verifyUploadImageButtons" >
10191019
<argument name="contentType" value="PageBuilderSliderContentType"/>
@@ -1026,7 +1026,7 @@
10261026
<waitForElementVisible selector="{{ImageOnConfigurationPanel.imageSource(PageBuilderImageProperty_JPG.fileName)}}" stepKey="waitForMainImageSource1"/>
10271027
<!--Upload image from Media Gallery Storage -->
10281028
<comment userInput="Upload image from Media Gallery Storage" stepKey="commentUploadImageFromStorage"/>
1029-
<click selector="{{SlideOnBackend.slideWrapper}}" stepKey="clickSliderInStage"/>
1029+
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusSlide2"/>
10301030
<waitForElementVisible selector="{{ImageOnStage.selectFromGalleryImageBtn}}" stepKey="seeSelectFromGalleryBtn2" />
10311031
<click selector="{{ImageOnStage.selectFromGalleryImageBtn}}" stepKey="clickSelectFromGallery" />
10321032
<waitForPageLoad stepKey="waitForPageLoad2" />
@@ -1091,7 +1091,7 @@
10911091
<argument name="property" value="PageBuilderAppearance_CollageLeft"/>
10921092
</actionGroup>
10931093
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings1"/>
1094-
<click selector="{{SlideOnBackend.slideWrapper}}" stepKey="clickSliderInStage1"/>
1094+
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusSlide"/>
10951095
<comment userInput="Verify there are 2 buttons when hovering" stepKey="commentVerifyButtons1" />
10961096
<actionGroup ref="verifyUploadImageButtons" stepKey="verifyUploadImageButtons1" >
10971097
<argument name="contentType" value="PageBuilderSliderContentType"/>
@@ -1105,7 +1105,7 @@
11051105
<argument name="property" value="PageBuilderAppearance_CollageCentered"/>
11061106
</actionGroup>
11071107
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings2"/>
1108-
<click selector="{{SlideOnBackend.slideWrapper}}" stepKey="clickSliderInStage2"/>
1108+
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusSlide2"/>
11091109
<comment userInput="Verify there are 2 buttons when hovering" stepKey="commentVerifyButtons2" />
11101110
<actionGroup ref="verifyUploadImageButtons" stepKey="verifyUploadImageButtons2" >
11111111
<argument name="contentType" value="PageBuilderSliderContentType"/>
@@ -1120,7 +1120,7 @@
11201120
</actionGroup>
11211121
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings3"/>
11221122
<!--Verify there are 2 buttons when hovering-->
1123-
<click selector="{{SlideOnBackend.slideWrapper}}" stepKey="clickSliderInStage3"/>
1123+
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusSlide3"/>
11241124
<comment userInput="Verify there are 2 buttons when hovering" stepKey="commentVerifyButtons3" />
11251125
<actionGroup ref="verifyUploadImageButtons" stepKey="verifyUploadImageButtons3" >
11261126
<argument name="contentType" value="PageBuilderSliderContentType"/>

0 commit comments

Comments
 (0)