#544: Configurable Page Builder Full Screen Mode

bluemwhitew · bluemwhitew · commit 162319b4092d · 2020-07-28T15:53:49.000+01:00
- Adding Configurable Option
- Setting Default Value
- Adding Translation String(s)
- Extending Existing Tests
diff --git a/app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderStoreConfigurationSection.xml b/app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderStoreConfigurationSection.xml
@@ -6,13 +6,13 @@
   */
 -->
 
-<sections xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-          xsi:noNamespaceSchemaLocation="urn:magento:mftf:Page/etc/SectionObject.xsd">
+<sections xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:mftf:Page/etc/SectionObject.xsd">
     <section name="ContentManagementSection">
         <element name="PageBuilderOptions" type="button" selector="#cms_pagebuilder-head"/>
         <element name="CheckIfPageBuilderTabExpanded" type="button" selector="#cms_pagebuilder-head:not(.open)"/>
         <element name="EnablePageBuilderSystemValue" type="button" selector="#cms_pagebuilder_enabled_inherit"/>
         <element name="EnablePageBuilder" type="button" selector="#cms_pagebuilder_enabled"/>
+        <element name="EnablePageBuilderContentPreview" type="button" selector="#cms_pagebuilder_enable_content_preview"/>
         <element name="DisclaimerMessage" type="text" selector="//aside[@data-type='popup']//div[@class='modal-inner-wrap']"/>
         <element name="CancelBtn" type="button" selector=".action-pagebuilder-cancel"/>
         <element name="TurnOffBtn" type="button" selector=".action-accept"/>
diff --git a/app/code/Magento/PageBuilder/Test/Mftf/Test/AdminStoreConfigurationPageBuilderEnableTest.xml b/app/code/Magento/PageBuilder/Test/Mftf/Test/AdminStoreConfigurationPageBuilderEnableTest.xml
@@ -6,8 +6,7 @@
   */
 -->
 
-<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-        xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
+<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
     <test name="VerifyPageBuilderSwitcherAndDisclaimerMessageTest">
         <annotations>
             <features value="PageBuilder"/>
@@ -40,6 +39,12 @@
             <actualResult type="variable">grabTextFromDisclaimerMsg</actualResult>
             <expectedResult type="string">Includes advanced tools to design page layouts, add Magento content (Product and Category data, CMS content and Blocks), and format text.\n\nFor Product Attributes — Page Builder can be selected as the “input type” to design layouts and create content.</expectedResult>
         </assertEquals>
+        <seeOptionIsSelected selector="{{ContentManagementSection.EnablePageBuilderContentPreview}}" userInput="Yes" stepKey="seeEnablePageBuilderContentPreview"/>
+        <grabTextFrom selector="//tr[@id='row_cms_pagebuilder_enable_content_preview']/td[@class='value']//span" stepKey="grabTextFromEnablePageBuilderContentPreviewComment"/>
+        <assertEquals message="pass" stepKey="assertEquals3">
+            <actualResult type="variable">grabTextFromEnablePageBuilderContentPreviewComment</actualResult>
+            <expectedResult type="string">Preview Page Builder content on product and category editing pages. Setting to "No" can improve performance in case several attributes are editable by Page Builder.</expectedResult>
+        </assertEquals>
         <!--Disable PageBuilder-->
         <comment userInput="Disable PageBuilder" stepKey="commentDisablePageBuilder"/>
         <selectOption selector="{{ContentManagementSection.EnablePageBuilder}}" userInput="No" stepKey="selectNO1"/>
@@ -52,6 +57,7 @@
         <waitForElementVisible selector="{{ContentManagementSection.DisclaimerMessage}}" stepKey="waitForPopUpMsg2"/>
         <click selector="{{ContentManagementSection.TurnOffBtn}}" stepKey="selectTurnOff" />
         <dontSee selector="{{ContentManagementSection.DisclaimerMessage}}" stepKey="popupClose2"/>
+        <dontSee selector="{{ContentManagementSection.EnablePageBuilderContentPreview}}" stepKey="dontSeeEnablePageBuilderContentPreview"/>
         <seeOptionIsSelected selector="{{ContentManagementSection.EnablePageBuilder}}" userInput="No" stepKey="seeNoIsSelected" />
         <click selector="{{ContentManagementSection.Save}}" stepKey="saveConfig" />
         <!-- I switch between NO -> YES - > NO without saving the Config, Then: Warning message will not appear on page-->
diff --git a/app/code/Magento/PageBuilder/etc/adminhtml/system.xml b/app/code/Magento/PageBuilder/etc/adminhtml/system.xml
@@ -18,6 +18,17 @@
                         <![CDATA[Includes advanced tools to design page layouts, add Magento content (Product and Category data, CMS content and Blocks), and format text.<br /><br />For Product Attributes — Page Builder can be selected as the “input type” to design layouts and create content.]]>
                     </comment>
                 </field>
+                <field id="enable_content_preview" translate="label comment" type="select" sortOrder="10" showInDefault="1" showInWebsite="0" showInStore="0">
+                    <depends>
+                        <field id="enabled">1</field>
+                    </depends>
+                    <label>Enable Page Builder Content Preview</label>
+                    <source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
+                    <frontend_model>Magento\PageBuilder\Block\Adminhtml\System\Config\EnableField</frontend_model>
+                    <comment>
+                        <![CDATA[Preview Page Builder content on product and category editing pages. Setting to "No" can improve performance in case several attributes are editable by Page Builder.]]>
+                    </comment>
+                </field>
                 <field id="google_maps_api_key" translate="label comment" type="text" sortOrder="2010" showInDefault="1" showInWebsite="0" showInStore="0">
                     <label>Google Maps API Key</label>
                     <comment>
diff --git a/app/code/Magento/PageBuilder/etc/config.xml b/app/code/Magento/PageBuilder/etc/config.xml
@@ -19,6 +19,7 @@
         <cms>
             <pagebuilder>
                 <enabled>1</enabled>
+                <enable_content_preview>1</enable_content_preview>
                 <column_grid_default>12</column_grid_default>
                 <column_grid_max>16</column_grid_max>
             </pagebuilder>
diff --git a/app/code/Magento/PageBuilder/i18n/en_US.csv b/app/code/Magento/PageBuilder/i18n/en_US.csv
@@ -70,6 +70,8 @@ Grid,Grid
 "Advanced Content Tools","Advanced Content Tools"
 "Enable Page Builder","Enable Page Builder"
 "Includes advanced tools to design page layouts, add Magento content (Product and Category data, CMS content and Blocks), and format text.<br /><br />For Product Attributes — Page Builder can be selected as the “input type” to design layouts and create content.","Includes advanced tools to design page layouts, add Magento content (Product and Category data, CMS content and Blocks), and format text.<br /><br />For Product Attributes — Page Builder can be selected as the “input type” to design layouts and create content."
+"Enable Page Builder Content Preview","Enable Page Builder Content Preview"
+"Preview Page Builder content on product and category editing pages. Setting to ""No"" can improve performance in case several attributes are editable by Page Builder.","Preview Page Builder content on product and category editing pages. Setting to ""No"" can improve performance in case several attributes are editable by Page Builder."
 Appearance,Appearance
 Title,Title
 Content,Content
