Skip to content

Commit 19dcd8d

Browse files
author
Michael Yu
committed
MC-2208: Update events to new naming convention
- Updated misnamed event
1 parent 0158af2 commit 19dcd8d

File tree

8 files changed

+9
-9
lines changed

8 files changed

+9
-9
lines changed

app/code/Magento/PageBuilder/docs/events.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ This document contains reference information for events dispatched in Page Build
5555
* [contentType:afterRender](#contenttypeafterrender)
5656
* [contentType:removeAfter](#contenttyperemoved)
5757
* [contentType:duplicateAfter](#contenttypeduplicate)
58-
* [contentType:beforeMove](#contenttypebeforemove)
58+
* [contentType:moveBefore](#contenttypemovebefore)
5959
* [contentType:moveAfter](#contenttypemoveafter)
6060
* [column:dragStart](#columdragstart)
6161
* [column:dragStop](#columndragstop)
@@ -210,7 +210,7 @@ All events starting with `contentType:` can also be called for specific content
210210

211211
[Back to top]
212212

213-
### `contentType:beforeMove`
213+
### `contentType:moveBefore`
214214

215215
**Triggers**
216216

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/tabs/preview.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/drag-drop/move-content-type.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/form/element/wysiwyg.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ define([
7777
events.on('stage:' + id + ':masterFormatRenderAfter', function (args) {
7878
this.value(args.value);
7979
}.bind(this));
80-
events.on('pagebuilder:' + id + ':fullScreen', function (args) {
80+
events.on(id + ':fullScreen', function (args) {
8181
if (!args.fullScreen && this.wysiwygConfigData()['pagebuilder_button']) {
8282
this.visiblePageBuilder(false);
8383
} else if (args.fullScreen && this.wysiwygConfigData()['pagebuilder_button']) {

app/code/Magento/PageBuilder/view/adminhtml/web/js/page-builder.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/tabs/preview.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ export default class Preview extends PreviewCollection {
6363
) {
6464
super(parent, config, observableUpdater);
6565

66-
events.on("tabs:contentType:afterRender", (args: ContentTypeAfterRenderEventParamsInterface) => {
66+
events.on("tabs:afterRender", (args: ContentTypeAfterRenderEventParamsInterface) => {
6767
if (args.id === this.parent.id && this.element) {
6868
this.buildTabs();
6969
}

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/drag-drop/move-content-type.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export function moveContentType(
2626
const sourceParentChildren = sourceParent.getChildren();
2727

2828
// Trigger our block move event
29-
events.trigger("contentType:beforeMove", {
29+
events.trigger("contentType:moveBefore", {
3030
contentType,
3131
sourceParent,
3232
targetParent,

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/page-builder.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ export default class PageBuilder implements PageBuilderInterface {
6363
});
6464
}
6565

66-
events.trigger(`pagebuilder:${ this.id }:fullScreen`, {
66+
events.trigger(`${ this.id }:fullScreen`, {
6767
fullScreen: this.isFullScreen(),
6868
});
6969
}

0 commit comments

Comments
 (0)