Skip to content

Commit 1d338fd

Browse files
committed
PB-266: Video background for Slide
- Adding tests
1 parent 33513e5 commit 1d338fd

File tree

2 files changed

+15
-15
lines changed

2 files changed

+15
-15
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearancePosterTests.xml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1735,7 +1735,7 @@
17351735
<argument name="property" value="PageBuilderAppearance_Poster"/>
17361736
</actionGroup>
17371737
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty">
1738-
<argument name="property" value="PageBuilderMinHeightProperty_200"/>
1738+
<argument name="property" value="PageBuilderMinHeightProperty_200px"/>
17391739
</actionGroup>
17401740
<actionGroup ref="chooseVisualSelectOption" stepKey="setBackgroundType">
17411741
<argument name="property" value="PageBuilderSlideItemBackgroundType_Video"/>
@@ -1869,7 +1869,7 @@
18691869
<argument name="property" value="PageBuilderAppearance_Poster"/>
18701870
</actionGroup>
18711871
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty">
1872-
<argument name="property" value="PageBuilderMinHeightProperty_200"/>
1872+
<argument name="property" value="PageBuilderMinHeightProperty_200px"/>
18731873
</actionGroup>
18741874
<!-- Update All Video Background Fields -->
18751875
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterBackgroundColor">
@@ -2026,11 +2026,11 @@
20262026
<argument name="property" value="PageBuilderAppearance_Poster"/>
20272027
</actionGroup>
20282028
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty">
2029-
<argument name="property" value="PageBuilderMinHeightProperty_200"/>
2029+
<argument name="property" value="PageBuilderMinHeightProperty_200px"/>
20302030
</actionGroup>
20312031
<!-- Update Video Background Fields -->
20322032
<actionGroup ref="chooseVisualSelectOption" stepKey="setBackgroundType">
2033-
<argument name="property" value="PageBuilderRowBackgroundType_Video"/>
2033+
<argument name="property" value="PageBuilderBackgroundType_Video"/>
20342034
</actionGroup>
20352035
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterVideoUrl">
20362036
<argument name="property" value="PageBuilderVideoBackgroundUrl_Invalid_VideoDoesNotExit"/>
@@ -2115,11 +2115,11 @@
21152115
<argument name="property" value="PageBuilderAppearance_Poster"/>
21162116
</actionGroup>
21172117
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty">
2118-
<argument name="property" value="PageBuilderMinHeightProperty_200"/>
2118+
<argument name="property" value="PageBuilderMinHeightProperty_200px"/>
21192119
</actionGroup>
21202120
<!-- Update Video Background Fields -->
21212121
<actionGroup ref="chooseVisualSelectOption" stepKey="setBackgroundType">
2122-
<argument name="property" value="PageBuilderRowBackgroundType_Video"/>
2122+
<argument name="property" value="PageBuilderBackgroundType_Video"/>
21232123
</actionGroup>
21242124
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterVideoUrl">
21252125
<argument name="property" value="PageBuilderVideoBackgroundUrl_Invalid_VideoDoesNotExit"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemCommonTest.xml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2189,7 +2189,7 @@
21892189
<argument name="section" value="SlideOnBackend"/>
21902190
</actionGroup>
21912191
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty">
2192-
<argument name="property" value="PageBuilderMinHeightProperty_200"/>
2192+
<argument name="property" value="PageBuilderMinHeightProperty_200px"/>
21932193
</actionGroup>
21942194
<actionGroup ref="chooseVisualSelectOption" stepKey="setBackgroundType">
21952195
<argument name="property" value="PageBuilderSlideItemBackgroundType_Video"/>
@@ -2360,7 +2360,7 @@
23602360
<argument name="property" value="PageBuilderAppearance_Poster"/>
23612361
</actionGroup>
23622362
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty">
2363-
<argument name="property" value="PageBuilderMinHeightProperty_200"/>
2363+
<argument name="property" value="PageBuilderMinHeightProperty_200px"/>
23642364
</actionGroup>
23652365
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterBackgroundColor">
23662366
<argument name="property" value="PageBuilderBackgroundColor_Pink"/>
@@ -2714,7 +2714,7 @@
27142714
<argument name="section" value="SlideOnBackend"/>
27152715
</actionGroup>
27162716
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty">
2717-
<argument name="property" value="PageBuilderMinHeightProperty_200"/>
2717+
<argument name="property" value="PageBuilderMinHeightProperty_200px"/>
27182718
</actionGroup>
27192719
<actionGroup ref="chooseVisualSelectOption" stepKey="setBackgroundType">
27202720
<argument name="property" value="PageBuilderSlideItemBackgroundType_Video"/>
@@ -2867,7 +2867,7 @@
28672867
<argument name="section" value="SlideOnBackend"/>
28682868
</actionGroup>
28692869
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty">
2870-
<argument name="property" value="PageBuilderMinHeightProperty_200"/>
2870+
<argument name="property" value="PageBuilderMinHeightProperty_200px"/>
28712871
</actionGroup>
28722872
<actionGroup ref="chooseVisualSelectOption" stepKey="setBackgroundType">
28732873
<argument name="property" value="PageBuilderSlideItemBackgroundType_Video"/>
@@ -2978,7 +2978,7 @@
29782978
<argument name="section" value="SlideOnBackend"/>
29792979
</actionGroup>
29802980
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty">
2981-
<argument name="property" value="PageBuilderMinHeightProperty_200"/>
2981+
<argument name="property" value="PageBuilderMinHeightProperty_200px"/>
29822982
</actionGroup>
29832983
<actionGroup ref="chooseVisualSelectOption" stepKey="setBackgroundType">
29842984
<argument name="property" value="PageBuilderSlideItemBackgroundType_Video"/>
@@ -3167,7 +3167,7 @@
31673167
<argument name="property" value="PageBuilderAppearance_Poster"/>
31683168
</actionGroup>
31693169
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty">
3170-
<argument name="property" value="PageBuilderMinHeightProperty_200"/>
3170+
<argument name="property" value="PageBuilderMinHeightProperty_200px"/>
31713171
</actionGroup>
31723172
<actionGroup ref="chooseVisualSelectOption" stepKey="setBackgroundType">
31733173
<argument name="property" value="PageBuilderSlideItemBackgroundType_Video"/>
@@ -3198,7 +3198,7 @@
31983198
<argument name="property" value="PageBuilderAppearance_CollageLeft"/>
31993199
</actionGroup>
32003200
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty1">
3201-
<argument name="property" value="PageBuilderMinHeightProperty_300"/>
3201+
<argument name="property" value="PageBuilderMinHeightProperty_300px"/>
32023202
</actionGroup>
32033203
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings1"/>
32043204
<!-- Configure Collage Center Slide appearance -->
@@ -3207,7 +3207,7 @@
32073207
<argument name="targetIndex" value="3"/>
32083208
</actionGroup>
32093209
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty2">
3210-
<argument name="property" value="PageBuilderMinHeightProperty_200"/>
3210+
<argument name="property" value="PageBuilderMinHeightProperty_200px"/>
32113211
</actionGroup>
32123212
<actionGroup ref="chooseVisualSelectOption" stepKey="setAppearance2">
32133213
<argument name="property" value="PageBuilderAppearance_CollageCentered"/>
@@ -3222,7 +3222,7 @@
32223222
<argument name="property" value="PageBuilderAppearance_CollageRight"/>
32233223
</actionGroup>
32243224
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty3">
3225-
<argument name="property" value="PageBuilderMinHeightProperty_500"/>
3225+
<argument name="property" value="PageBuilderMinHeightProperty_500px"/>
32263226
</actionGroup>
32273227
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings3"/>
32283228
<executeJS function="return parseInt(&quot;{{PageBuilderVideoBackgroundUrl_Mp4_URL_Insecure.width}}&quot;) / parseInt(&quot;{{PageBuilderVideoBackgroundUrl_Mp4_URL_Insecure.height}}&quot;)" stepKey="expectedVideoAspectRatio"/>

0 commit comments

Comments
 (0)