Skip to content

Commit 2230dd3

Browse files
committed
MAGETWO-92821: [Tech Debt] Update slide & slider forms to use true / false values instead of 0 / 1
- Update number values to true or false strings
1 parent 95e26d9 commit 2230dd3

File tree

2 files changed

+15
-15
lines changed

2 files changed

+15
-15
lines changed

app/code/Magento/PageBuilder/view/adminhtml/ui_component/pagebuilder_slider_form.xml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,8 @@
9090
<checkbox>
9191
<settings>
9292
<valueMap>
93-
<map name="false" xsi:type="number">0</map>
94-
<map name="true" xsi:type="number">1</map>
93+
<map name="false" xsi:type="string">false</map>
94+
<map name="true" xsi:type="string">true</map>
9595
</valueMap>
9696
<prefer>toggle</prefer>
9797
</settings>
@@ -129,8 +129,8 @@
129129
<checkbox>
130130
<settings>
131131
<valueMap>
132-
<map name="false" xsi:type="number">0</map>
133-
<map name="true" xsi:type="number">1</map>
132+
<map name="false" xsi:type="string">false</map>
133+
<map name="true" xsi:type="string">true</map>
134134
</valueMap>
135135
<prefer>toggle</prefer>
136136
</settings>
@@ -151,8 +151,8 @@
151151
<checkbox>
152152
<settings>
153153
<valueMap>
154-
<map name="false" xsi:type="number">0</map>
155-
<map name="true" xsi:type="number">1</map>
154+
<map name="false" xsi:type="string">false</map>
155+
<map name="true" xsi:type="string">true</map>
156156
</valueMap>
157157
<prefer>toggle</prefer>
158158
</settings>
@@ -173,8 +173,8 @@
173173
<checkbox>
174174
<settings>
175175
<valueMap>
176-
<map name="false" xsi:type="number">0</map>
177-
<map name="true" xsi:type="number">1</map>
176+
<map name="false" xsi:type="string">false</map>
177+
<map name="true" xsi:type="string">true</map>
178178
</valueMap>
179179
<prefer>toggle</prefer>
180180
</settings>
@@ -195,8 +195,8 @@
195195
<checkbox>
196196
<settings>
197197
<valueMap>
198-
<map name="false" xsi:type="number">0</map>
199-
<map name="true" xsi:type="number">1</map>
198+
<map name="false" xsi:type="string">false</map>
199+
<map name="true" xsi:type="string">true</map>
200200
</valueMap>
201201
<prefer>toggle</prefer>
202202
</settings>

app/code/Magento/PageBuilder/view/frontend/web/js/default.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -75,12 +75,12 @@ requirejs([
7575
}
7676

7777
$(element).slick({
78-
autoplay: $(element).data('autoplay') === 1,
78+
autoplay: $(element).data('autoplay'),
7979
autoplaySpeed: $(element).data('autoplay-speed') || 0,
80-
fade: $(element).data('fade') === 1,
81-
infinite: $(element).data('is-infinite') === 1,
82-
arrows: $(element).data('show-arrows') === 1,
83-
dots: $(element).data('show-dots') === 1
80+
fade: $(element).data('fade'),
81+
infinite: $(element).data('is-infinite'),
82+
arrows: $(element).data('show-arrows'),
83+
dots: $(element).data('show-dots')
8484
});
8585
}
8686
});

0 commit comments

Comments
 (0)