Skip to content

Commit 225a267

Browse files
MAGETWO-91974: [Testing] Create/Update Automated Tests
- remove validateVisualSelectOptionIsSelected action group and use existing one
1 parent 25edc69 commit 225a267

File tree

2 files changed

+8
-15
lines changed

2 files changed

+8
-15
lines changed

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/PageBuilder/ActionGroup/ActionGroup.xml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -447,13 +447,6 @@
447447
<seeElement selector='//li[@name="{{property.value}}"]' stepKey="seeVisualSelect"/>
448448
<click selector='//div[@data-index="{{property.section}}" and contains(@class,"_show")]//li[@name="{{property.value}}"]' stepKey="chooseVisualSelectOption"/>
449449
</actionGroup>
450-
<actionGroup name="validateVisualSelectOptionIsSelected">
451-
<arguments>
452-
<argument name="property" defaultValue=""/>
453-
</arguments>
454-
<waitForElement time="2" selector="{{PageBuilderActionsSection.panelFieldControl(property.section, property.fieldName)}}" stepKey="waitForElementVisible" />
455-
<seeElement selector='//li[@name="{{property.value}}" and contains(@class, "active")]' stepKey="seeVisualSelectActive"/>
456-
</actionGroup>
457450
<actionGroup name="validateAlignmentFieldIsNotDisabled">
458451
<arguments>
459452
<argument name="property" defaultValue=""/>

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/PageBuilder/Test/AdminPageBuilderButtonGroupTests.xml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -595,7 +595,7 @@
595595
</actionGroup>
596596
<!-- Validate Default Values -->
597597
<comment userInput="Validate Default Values" stepKey="CommentValidateDefaultValues"/>
598-
<actionGroup ref="validateVisualSelectOptionIsSelected" stepKey="seeAppearanceIsSelected">
598+
<actionGroup ref="seeOptionIsSelectedSlideOutProperty" stepKey="validateInlineAppearance">
599599
<argument name="property" value="PageBuilderAppearancePropertyInline"/>
600600
</actionGroup>
601601
<actionGroup ref="closeEditPanelSettings" stepKey="closeEditPanelSettings"/>
@@ -618,7 +618,7 @@
618618
</actionGroup>
619619
<!-- Validate Edit Panel After Save -->
620620
<comment userInput="Validate Edit Panel After Save" stepKey="commentValidateEditPanel2"/>
621-
<actionGroup ref="validateVisualSelectOptionIsSelected" stepKey="seeAppearanceIsSelected2">
621+
<actionGroup ref="seeOptionIsSelectedSlideOutProperty" stepKey="validateInlineAppearance2">
622622
<argument name="property" value="PageBuilderAppearancePropertyInline"/>
623623
</actionGroup>
624624
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
@@ -717,7 +717,7 @@
717717
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearance">
718718
<argument name="property" value="PageBuilderAppearancePropertyInline"/>
719719
</actionGroup>
720-
<actionGroup ref="validateVisualSelectOptionIsSelected" stepKey="seeAppearanceIsSelected">
720+
<actionGroup ref="seeOptionIsSelectedSlideOutProperty" stepKey="validateInlineAppearance">
721721
<argument name="property" value="PageBuilderAppearancePropertyInline"/>
722722
</actionGroup>
723723
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings1"/>
@@ -750,7 +750,7 @@
750750
</actionGroup>
751751
<!-- Validate Edit Panel After Save -->
752752
<comment userInput="Validate Edit Panel After Save" stepKey="commentValidateEditPanel2"/>
753-
<actionGroup ref="validateVisualSelectOptionIsSelected" stepKey="seeAppearanceIsSelected2">
753+
<actionGroup ref="seeOptionIsSelectedSlideOutProperty" stepKey="validateInlineAppearance2">
754754
<argument name="property" value="PageBuilderAppearancePropertyInline"/>
755755
</actionGroup>
756756
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
@@ -804,7 +804,7 @@
804804
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearance">
805805
<argument name="property" value="PageBuilderAppearancePropertyStacked"/>
806806
</actionGroup>
807-
<actionGroup ref="validateVisualSelectOptionIsSelected" stepKey="seeAppearanceIsSelected">
807+
<actionGroup ref="seeOptionIsSelectedSlideOutProperty" stepKey="validateStackedAppearance">
808808
<argument name="property" value="PageBuilderAppearancePropertyStacked"/>
809809
</actionGroup>
810810
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings1"/>
@@ -827,7 +827,7 @@
827827
</actionGroup>
828828
<!-- Validate Edit Panel After Save -->
829829
<comment userInput="Validate Edit Panel After Save" stepKey="commentValidateEditPanel2"/>
830-
<actionGroup ref="validateVisualSelectOptionIsSelected" stepKey="seeAppearanceIsSelected2">
830+
<actionGroup ref="seeOptionIsSelectedSlideOutProperty" stepKey="validateStackedAppearance2">
831831
<argument name="property" value="PageBuilderAppearancePropertyStacked"/>
832832
</actionGroup>
833833
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
@@ -1253,7 +1253,7 @@
12531253
</actionGroup>
12541254
<!-- Select Inline Appearance -->
12551255
<comment userInput="Select Inline Appearance" stepKey="CommentSelectInlineAppearance"/>
1256-
<actionGroup ref="chooseVisualSelectOption" stepKey="enterStackedAlignment">
1256+
<actionGroup ref="chooseVisualSelectOption" stepKey="enterInlineAppearance">
12571257
<argument name="property" value="PageBuilderAppearancePropertyInline"/>
12581258
</actionGroup>
12591259
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings1"/>
@@ -1311,7 +1311,7 @@
13111311
</actionGroup>
13121312
<!-- Select Inline Appearance -->
13131313
<comment userInput="Select Inline Appearance" stepKey="CommentSelectInlineAppearance2"/>
1314-
<actionGroup ref="chooseVisualSelectOption" stepKey="enterInlineAppearance">
1314+
<actionGroup ref="chooseVisualSelectOption" stepKey="enterInlineAppearance2">
13151315
<argument name="property" value="PageBuilderAppearancePropertyInline"/>
13161316
</actionGroup>
13171317
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings3"/>

0 commit comments

Comments
 (0)