Skip to content

Commit 231c26b

Browse files
committed
MC-2374: Create MFTF Tests
- Resolve CR comments - Add section in docs describing disabling Page builder module
1 parent 657e190 commit 231c26b

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminCreateCategoryTest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@
134134
<click selector="{{PageBuilderStage.exitFullScreen}}" stepKey="exitPageBuilderFullScreen" />
135135
<waitForPageLoad stepKey="waitForPageLoadExitFullScreen"/>
136136
<!-- Set Layout to Page - Full Width -->
137-
<comment userInput="Set Layout to Category - Full Width" stepKey="commentSetLayout"/>
137+
<comment userInput="Set Layout to Page - Full Width" stepKey="commentSetLayout"/>
138138
<actionGroup ref="setLayout" stepKey="setFullWidthLayout">
139139
<argument name="designSection" value="CategoryDesignSection"/>
140140
<argument name="layoutOption" value="PageBuilderFullWidthLayout.cms"/>
@@ -151,7 +151,7 @@
151151
<argument name="Category" value="_defaultCategory"/>
152152
</actionGroup>
153153
<!-- Set Layout to Product - Full Width -->
154-
<comment userInput="Set Layout to Category - Full Width" stepKey="commentSetLayout2"/>
154+
<comment userInput="Set Layout to Product - Full Width" stepKey="commentSetLayout2"/>
155155
<actionGroup ref="setLayout" stepKey="setFullWidthLayout2">
156156
<argument name="designSection" value="CategoryDesignSection"/>
157157
<argument name="layoutOption" value="PageBuilderFullWidthLayout.product"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminCreateProductTest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@
129129
</actionGroup>
130130
<click selector="{{PageBuilderStage.exitFullScreen}}" stepKey="exitPageBuilderFullScreen" />
131131
<waitForPageLoad stepKey="waitForPageLoadExitFullScreen"/>
132-
<!-- Use Category Full Width layout -->
132+
<!-- Set Layout to Category - Full Width -->
133133
<comment userInput="Set Layout to Category - Full Width" stepKey="commentSetLayout"/>
134134
<actionGroup ref="setLayout" stepKey="setCategoryFullWidthLayout">
135135
<argument name="designSection" value="ProductDesignSection"/>
@@ -152,7 +152,7 @@
152152
<actionGroup ref="OpenEditProductOnBackendActionGroup" stepKey="openEditProduct">
153153
<argument name="product" value="_defaultProduct"/>
154154
</actionGroup>
155-
<!-- Use Page Full Width layout -->
155+
<!-- Set Layout to Page - Full Width -->
156156
<comment userInput="Set Layout to Page - Full Width" stepKey="commentSetLayout2"/>
157157
<actionGroup ref="setLayout" stepKey="setPageFullWidthLayout">
158158
<argument name="designSection" value="ProductDesignSection"/>

app/code/Magento/PageBuilder/docs/full-width-page-layouts.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,3 +134,6 @@ In `product-full-width.xml`, we create a new wrapper for product details & descr
134134
We cannot guarantee these full-width layouts will work as expected with your custom themes as your page's structure may differ from Luma's.
135135

136136
To enable full width within your custom themes, you must ensure the appropriate block is not within your page's main wrapper. This implementation will differ on a case-by-case basis but the above implementations for Luma should give you a good indication on how to approach these.
137+
138+
## Disabling Page Builder
139+
If you apply one of our custom layouts to an entity and then disable or remove the Page Builder module you'll be required to manually update those entities with new page layouts. This is due to disabling Page Builder will make the new full width layouts unavailable thus causing entities to render incorrectly.

0 commit comments

Comments
 (0)