Skip to content

Commit 2759639

Browse files
committed
Merge from 559_no-predefined-gutters--text
2 parents 7b4274b + afc5379 commit 2759639

File tree

3 files changed

+24
-9
lines changed

3 files changed

+24
-9
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Data/TextData.xml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,7 @@
55
* See COPYING.txt for license details.
66
*/
77
-->
8-
9-
<entities xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
10-
xsi:noNamespaceSchemaLocation="urn:magento:mftf:DataGenerator/etc/dataProfileSchema.xsd">
8+
<entities xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:mftf:DataGenerator/etc/dataProfileSchema.xsd">
119
<!-- Text -->
1210
<entity name="PageBuilderTextProperty" type="pagebuilder_text_property">
1311
<data key="name">Text</data>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderTextTest/TextValidateAdvancedConfigurationDefaultValuesTest.xml

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@
55
* See COPYING.txt for license details.
66
*/
77
-->
8-
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
9-
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
8+
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
109
<test name="TextValidateAdvancedConfigurationDefaultValuesTest">
1110
<annotations>
1211
<features value="PageBuilder"/>
@@ -43,6 +42,7 @@
4342
<actionGroup ref="addTextToTinyMCE" stepKey="enterText">
4443
<argument name="property" value="PageBuilderTextProperty"/>
4544
</actionGroup>
45+
4646
<!-- Validate Edit Panel -->
4747
<comment userInput="Validate Edit Panel" stepKey="commentValidateEditPanel"/>
4848
<actionGroup ref="seeOptionIsSelectedSlideOutProperty" stepKey="validateAlignment">
@@ -66,12 +66,15 @@
6666
<actualResult type="variable">getCssClasses</actualResult>
6767
</assertEmpty>
6868
<actionGroup ref="seeInMarginFieldsSlideOutPanel" stepKey="validateMargins">
69-
<argument name="property" value="PageBuilderMarginsPropertyDefault"/>
69+
<!-- @todo: Update `PageBuilderMarginsPropertyDefault` with (Default) Empty Values -->
70+
<argument name="property" value="PageBuilderMarginsProperty_Empty"/>
7071
</actionGroup>
7172
<actionGroup ref="seeInPaddingFieldsSlideOutPanel" stepKey="validatePadding">
72-
<argument name="property" value="PageBuilderPaddingPropertyDefault"/>
73+
<!-- @todo: Update `PageBuilderPaddingPropertyDefault` with (Default) Empty Values -->
74+
<argument name="property" value="PageBuilderPaddingProperty_Empty"/>
7375
</actionGroup>
7476
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
77+
7578
<!-- Validate Stage -->
7679
<comment userInput="Validate Stage" stepKey="commentValidateStage"/>
7780
<actionGroup ref="ValidateAdvancedConfigurationWithNoAlignmentActionGroup" stepKey="validateStage">
@@ -81,6 +84,7 @@
8184
<actionGroup ref="exitPageBuilderFullScreen" stepKey="exitPageBuilderFullScreen"/>
8285
<actionGroup ref="SaveAndContinueEditCmsPageActionGroup" stepKey="saveAndContinueEditCmsPage"/>
8386
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
87+
8488
<!-- Validate Stage After Save -->
8589
<comment userInput="Validate Stage After Save" stepKey="commentValidateStage2"/>
8690
<actionGroup ref="ValidateAdvancedConfigurationWithNoAlignmentActionGroup" stepKey="validateStage2">
@@ -90,6 +94,7 @@
9094
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage2">
9195
<argument name="contentType" value="PageBuilderTextContentType"/>
9296
</actionGroup>
97+
9398
<!-- Validate Edit Panel After Save -->
9499
<comment userInput="Validate Edit Panel After Save" stepKey="commentValidateEditPanel2"/>
95100
<actionGroup ref="seeOptionIsSelectedSlideOutProperty" stepKey="validateAlignment2">
@@ -113,14 +118,17 @@
113118
<actualResult type="variable">getCssClasses2</actualResult>
114119
</assertEmpty>
115120
<actionGroup ref="seeInMarginFieldsSlideOutPanel" stepKey="validateMargins2">
116-
<argument name="property" value="PageBuilderMarginsPropertyDefault"/>
121+
<!-- @todo: Update `PageBuilderMarginsPropertyDefault` with (Default) Empty Values -->
122+
<argument name="property" value="PageBuilderMarginsProperty_Empty"/>
117123
</actionGroup>
118124
<actionGroup ref="seeInPaddingFieldsSlideOutPanel" stepKey="validatePadding2">
119-
<argument name="property" value="PageBuilderPaddingPropertyDefault"/>
125+
<!-- @todo: Update `PageBuilderPaddingPropertyDefault` with (Default) Empty Values -->
126+
<argument name="property" value="PageBuilderPaddingProperty_Empty"/>
120127
</actionGroup>
121128
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
122129
<argument name="contentType" value="PageBuilderTextContentType"/>
123130
</actionGroup>
131+
124132
<!-- Validate Storefront -->
125133
<comment userInput="Validate Storefront" stepKey="commentValidateStorefront"/>
126134
<actionGroup ref="ValidateAdvancedConfigurationWithNoAlignmentActionGroup" stepKey="validateStorefront">

app/code/Magento/PageBuilder/view/adminhtml/ui_component/pagebuilder_text_form.xml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,4 +100,13 @@
100100
</formElements>
101101
</field>
102102
</fieldset>
103+
<fieldset name="advanced">
104+
<field name="margins_and_padding">
105+
<argument name="data" xsi:type="array">
106+
<item name="config" xsi:type="array">
107+
<item name="default" xsi:type="null" />
108+
</item>
109+
</argument>
110+
</field>
111+
</fieldset>
103112
</form>

0 commit comments

Comments
 (0)