Skip to content

Commit 2ccb26e

Browse files
committed
MC-4128: Minimum Height doesn't work with Parallax turned ON for Row Content Type on stage preview
Add RowMinimumHeightIsObeyedWhenParallaxIsEnabled
1 parent 79e19d0 commit 2ccb26e

File tree

2 files changed

+64
-0
lines changed

2 files changed

+64
-0
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Data/RowData.xml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,4 +122,16 @@
122122
<data key="fieldName">parallax_speed</data>
123123
<data key="value">2.0</data>
124124
</entity>
125+
<entity name="PageBuilderRowMinimumHeightProperty" type="pagebuilder_row_minimumHeight_property">
126+
<data key="name">Minimum Height</data>
127+
<data key="section">layout</data>
128+
<data key="fieldName">min_height</data>
129+
<data key="value">450</data>
130+
</entity>
131+
<entity name="PageBuilderRowMinimumHeightProperty_2" type="pagebuilder_row_minimumHeight_property">
132+
<data key="name">Minimum Height</data>
133+
<data key="section">layout</data>
134+
<data key="fieldName">min_height</data>
135+
<data key="value">400</data>
136+
</entity>
125137
</entities>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderRowTest.xml

Lines changed: 52 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1832,4 +1832,56 @@
18321832
<argument name="containerTargetIndex" value="1" />
18331833
</actionGroup>
18341834
</test>
1835+
<test name="RowMinimumHeightIsObeyedWhenParallaxIsEnabled">
1836+
<annotations>
1837+
<features value="PageBuilder"/>
1838+
<stories value="Row"/>
1839+
<title value="Row - Minimum Height Obeyed when Parallax is enabled"/>
1840+
<description value="As a Content Manager I want minimum height of parallax-enabled row to reflect the same value configured by user"/>
1841+
<severity value="CRITICAL"/>
1842+
<useCaseId value="MC-4128"/>
1843+
<testCaseId value="MC-4304"/>
1844+
<group value="pagebuilder"/>
1845+
<group value="pagebuilder-row"/>
1846+
<group value="pagebuilder-rowParallax"/>
1847+
</annotations>
1848+
<before>
1849+
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
1850+
<actionGroup ref="navigateToAPageWithPageBuilder" stepKey="navigateToAPageWithPageBuilder"/>
1851+
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
1852+
</before>
1853+
<after>
1854+
<actionGroup ref="logout" stepKey="logout"/>
1855+
</after>
1856+
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
1857+
<argument name="contentType" value="PageBuilderRowContentType"/>
1858+
</actionGroup>
1859+
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage">
1860+
<argument name="contentType" value="PageBuilderRowContentType"/>
1861+
</actionGroup>
1862+
<actionGroup ref="clickSlideOutPanelFieldGeneral" stepKey="enterParallaxEnabledProperty">
1863+
<argument name="property" value="PageBuilderRowParallax_Default"/>
1864+
</actionGroup>
1865+
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinimumHeightProperty">
1866+
<argument name="property" value="PageBuilderRowMinimumHeightProperty"/>
1867+
</actionGroup>
1868+
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings3"/>
1869+
<executeJS function="return parseInt(document.evaluate(&quot;{{RowOnStage.base('1')}}&quot;, document.body).iterateNext().style.minHeight, 10)" stepKey="computedHeight" />
1870+
<assertEquals stepKey="assertEqualToEnteredValue">
1871+
<expectedResult type="string">{{PageBuilderRowMinimumHeightProperty.value}}</expectedResult>
1872+
<actualResult type="variable">$computedHeight</actualResult>
1873+
</assertEquals>
1874+
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage2">
1875+
<argument name="contentType" value="PageBuilderRowContentType"/>
1876+
</actionGroup>
1877+
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinimumHeightProperty2">
1878+
<argument name="property" value="PageBuilderRowMinimumHeightProperty_2"/>
1879+
</actionGroup>
1880+
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings4"/>
1881+
<executeJS function="return parseInt(document.evaluate(&quot;{{RowOnStage.base('1')}}&quot;, document.body).iterateNext().style.minHeight, 10)" stepKey="computedHeight2" />
1882+
<assertEquals stepKey="assertEqualToEnteredValue2">
1883+
<expectedResult type="string">{{PageBuilderRowMinimumHeightProperty_2.value}}</expectedResult>
1884+
<actualResult type="variable">$computedHeight2</actualResult>
1885+
</assertEquals>
1886+
</test>
18351887
</tests>

0 commit comments

Comments
 (0)