MC-5691: Implement better developer error reporting

- Ensure promises console out any errors generated within

Author: davemacaulay

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/column-group/factory.js

@@ -29,5 +29,8 @@ export function createColumn(
     ).then((column: ContentTypeCollectionInterface<ColumnPreview>) => {
         parent.addChild(column, index);
         return column;
+    }).catch((error) => {
+        console.error(error);
+        return null;
     });
 }

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/preview.js

@@ -312,7 +312,7 @@ export default class Preview {
         contentType: ContentTypeInterface | ContentTypeCollectionInterface,
         autoAppend: boolean = true,
         direct: boolean = false,
-    ): Promise<ContentTypeInterface> | void {
+    ): Promise<ContentTypeInterface> {
         const contentTypeData = contentType.dataStore.get() as DataObject;
         const index = contentType.parent.getChildren()().indexOf(contentType) + 1 || null;
 
@@ -331,6 +331,9 @@ export default class Preview {
 
                 resolve(duplicateContentType);
             });
+        }).catch((error) => {
+            console.error(error);
+            return null;
         });
     }
 
@@ -461,14 +464,14 @@ export default class Preview {
     /**
      * Dispatch content type clone events
      *
-     * @param {ContentTypeInterface} originalContentType
-     * @param {ContentTypeInterface} duplicateContentType
+     * @param {ContentTypeInterface | ContentTypeCollectionInterface} originalContentType
+     * @param {ContentTypeInterface | ContentTypeCollectionInterface} duplicateContentType
      * @param {number} index
      * @param {boolean} direct
      */
     protected dispatchContentTypeCloneEvents(
-        originalContentType: ContentTypeInterface,
-        duplicateContentType: ContentTypeInterface,
+        originalContentType: ContentTypeInterface | ContentTypeCollectionInterface,
+        duplicateContentType: ContentTypeInterface | ContentTypeCollectionInterface,
         index: number,
         direct: boolean,
     ) {

app/code/Magento/PageBuilder/view/adminhtml/web/js/master-format/render.js

@@ -38,6 +38,9 @@ export default class MasterFormatRenderer {
                     },
                 },
             );
+        }).catch((error) => {
+            console.error(error);
+            return null;
         });
     }
 }

app/code/Magento/PageBuilder/view/adminhtml/web/js/panel.js

@@ -3,6 +3,7 @@
  * See COPYING.txt for license details.
  */
 
+import consoleLogger from "consoleLogger";
 import $ from "jquery";
 import ko from "knockout";
 import $t from "mage/translate";
@@ -268,7 +269,8 @@ export default class Panel implements PanelInterface {
             }
 
         } else {
-            console.warn("Configuration is not properly initialized, please check the Ajax response.");
+            consoleLogger.error("Unable to retrieve content types from server, please inspect network requests " +
+                "response.");
         }
     }
 }