MC-3934: Slide/Banner Overlay & Button Do Not Show On Storefront When Set To On Hover

Tweak unit test to prevent calling window.open

Author: danmooney2

app/code/Magento/PageBuilder/view/base/web/js/widget/click-event-binder.js

@@ -45,11 +45,11 @@ define(['jquery'], function ($) {
      * @param {String} target
      */
     clickEventBinder.redirectTo = function (href, target) {
-        if (target === '_blank') {
-            window.open(href, target);
-        } else {
-            window.location.href = href;
+        if (!target) {
+            target = '_self';
         }
+
+        window.open(href, target, 'noopener');
     };
 
     return clickEventBinder;

dev/tests/js/jasmine/tests/app/code/Magento/PageBuilder/view/frontend/web/js/widget/click-event-binder.test.js

@@ -8,8 +8,7 @@ define([
 ], function (clickEventBinderInitializerWidget, $) {
     'use strict';
 
-    var $el,
-        originalRedirectTo = clickEventBinderInitializerWidget.redirectTo;
+    var $el;
 
     afterEach(function () {
         if ($el !== undefined) {
@@ -18,9 +17,8 @@ define([
     });
 
     describe('Magento_PageBuilder/js/widget/click-event-binder', function () {
-        it('Should not navigate away from page if it is missing href attribute', function () {
+        it('Should not navigate away from page if it is missing data-href attribute', function () {
             spyOn(clickEventBinderInitializerWidget, 'redirectTo');
-            spyOn(window, 'open');
 
             $el = $(
                 '<div data-role="content-type">' +
@@ -38,12 +36,10 @@ define([
             $el.find('.span-outside-inner-anchor').click();
 
             expect(clickEventBinderInitializerWidget.redirectTo).not.toHaveBeenCalled();
-            expect(window.open).not.toHaveBeenCalled();
         });
 
-        it('Should not navigate away from page if href is javascript:void(0)', function () {
+        it('Should not navigate away from page if data-href is javascript:void(0)', function () {
             spyOn(clickEventBinderInitializerWidget, 'redirectTo');
-            spyOn(window, 'open');
 
             $el = $(
                 '<div data-role="content-type">' +
@@ -61,12 +57,10 @@ define([
             $el.find('.span-outside-inner-anchor').click();
 
             expect(clickEventBinderInitializerWidget.redirectTo).not.toHaveBeenCalled();
-            expect(window.open).not.toHaveBeenCalled();
         });
 
         it('Should not navigate away from page if it is missing data-link-type attribute', function () {
             spyOn(clickEventBinderInitializerWidget, 'redirectTo');
-            spyOn(window, 'open');
 
             $el = $(
                 '<div data-role="content-type">' +
@@ -84,12 +78,10 @@ define([
             $el.find('.span-outside-inner-anchor').click();
 
             expect(clickEventBinderInitializerWidget.redirectTo).not.toHaveBeenCalled();
-            expect(window.open).not.toHaveBeenCalled();
         });
 
-        it('Should not navigate to simulated anchor\'s href if clicked inside of nested anchor', function () {
+        it('Should not navigate to simulated anchor\'s data-href if clicked inside of nested anchor', function () {
             spyOn(clickEventBinderInitializerWidget, 'redirectTo');
-            spyOn(window, 'open');
 
             $el = $(
                 '<div data-role="content-type">' +
@@ -107,12 +99,10 @@ define([
             $el.find('.inner-anchor').click();
 
             expect(clickEventBinderInitializerWidget.redirectTo).not.toHaveBeenCalled();
-            expect(window.open).not.toHaveBeenCalled();
         });
 
-        it('Should navigate to simulated anchor\'s href if clicked outside of nested anchor', function () {
+        it('Should navigate to simulated anchor\'s data-href if clicked outside of nested anchor', function () {
             spyOn(clickEventBinderInitializerWidget, 'redirectTo');
-            spyOn(window, 'open');
 
             $el = $(
                 '<div data-role="content-type">' +
@@ -130,13 +120,9 @@ define([
             $el.find('.span-outside-inner-anchor').click();
 
             expect(clickEventBinderInitializerWidget.redirectTo).toHaveBeenCalledWith('https://adobe.com', '');
-
-            originalRedirectTo('https://adobe.com', '');
-            expect(window.open).not.toHaveBeenCalled();
         });
 
-        it('Should call window.open if data-target is _blank', function () {
-            spyOn(window, 'open');
+        it('Should call .redirectTo with _blank target if data-target is _blank', function () {
             spyOn(clickEventBinderInitializerWidget, 'redirectTo');
 
             $el = $(
@@ -155,9 +141,6 @@ define([
             $el.find('.span-outside-inner-anchor').click();
 
             expect(clickEventBinderInitializerWidget.redirectTo).toHaveBeenCalledWith('https://adobe.com', '_blank');
-
-            originalRedirectTo('https://adobe.com', '_blank');
-            expect(window.open).toHaveBeenCalledWith('https://adobe.com', '_blank');
         });
     });
 });