Skip to content

Commit 346b4a1

Browse files
omiroshnichenkoomiroshnichenko
committed
PB-379: Full height Slider/Slide
- fix failed tests
1 parent 74ce92a commit 346b4a1

File tree

2 files changed

+24
-21
lines changed

2 files changed

+24
-21
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBlockRenderMediaContentTypesTests.xml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1257,7 +1257,7 @@
12571257
<seeElement selector="{{SliderOnStage.minHeight('1', PageBuilderMinHeightProperty_500px.value)}}" stepKey="seeMinHeightCMSBlockStage"/>
12581258
<actionGroup ref="validateContentTypeHeightEqualToMinHeightPlusPaddingAndBorder" stepKey="validateHeightSlide1CMSBlockStage">
12591259
<argument name="content" value="{{SlideOnBackend.wrapperCSS}}"/>
1260-
<argument name="height" value="{{PageBuilderMinHeightProperty_300px.intValue}}"/>
1260+
<argument name="minHeight" value="{{PageBuilderMinHeightProperty_300px.intValue}}"/>
12611261
<argument name="index" value="1"/>
12621262
</actionGroup>
12631263
<click selector="{{SliderOnStage.slideNavigationDot('1', '1')}}" stepKey="clickSlide1CMSBlockStage"/>
@@ -1280,7 +1280,7 @@
12801280
<seeElement selector="{{SlideOnBackend.messageContent('2', PageBuilderSlideItemContent_Slide2.value)}}" stepKey="seeSlide2ContentCMSBlockStage3"/>
12811281
<actionGroup ref="validateContentTypeHeightEqualToMinHeightPlusPaddingAndBorder" stepKey="validateHeightSlide2CMSBlockStage">
12821282
<argument name="content" value="{{SlideOnBackend.wrapperCSS}}"/>
1283-
<argument name="height" value="{{PageBuilderMinHeightProperty_500px.intValue}}"/>
1283+
<argument name="minHeight" value="{{PageBuilderMinHeightProperty_500px.intValue}}"/>
12841284
<argument name="index" value="2"/>
12851285
</actionGroup>
12861286
<!-- Add Block to CMS Page -->
@@ -1312,7 +1312,7 @@
13121312
<seeElement selector="{{SliderOnFrontend.minHeight('1', PageBuilderMinHeightProperty_500px.value)}}" stepKey="seeHeightCMSPageStage"/>
13131313
<actionGroup ref="validateContentTypeHeightEqualToMinHeightPlusPaddingAndBorder" stepKey="validateHeightSlide1CMSPageStage">
13141314
<argument name="content" value="{{SlideOnFrontend.wrapperCSS}}"/>
1315-
<argument name="height" value="{{PageBuilderMinHeightProperty_300px.intValue}}"/>
1315+
<argument name="minHeight" value="{{PageBuilderMinHeightProperty_300px.intValue}}"/>
13161316
<argument name="index" value="1"/>
13171317
</actionGroup>
13181318
<actionGroup ref="SaveAndContinueEditCmsPageActionGroup" stepKey="saveAndContinueEditCmsPage"/>
@@ -1330,7 +1330,7 @@
13301330
<seeElement selector="{{SliderOnFrontend.minHeight('1', PageBuilderMinHeightProperty_500px.value)}}" stepKey="seeHeightCMSPageStorefront"/>
13311331
<actionGroup ref="validateContentTypeHeightEqualToMinHeightPlusPaddingAndBorder" stepKey="validateHeightSlide1CMSPageStorefront">
13321332
<argument name="content" value="{{SlideOnFrontend.wrapperCSS}}"/>
1333-
<argument name="height" value="{{PageBuilderMinHeightProperty_300px.intValue}}"/>
1333+
<argument name="minHeight" value="{{PageBuilderMinHeightProperty_300px.intValue}}"/>
13341334
<argument name="index" value="1"/>
13351335
</actionGroup>
13361336
<click selector="{{SliderOnFrontend.slideNavigationDot('1', '1')}}" stepKey="clickSlide1CMSPageStorefront"/>
@@ -1353,7 +1353,7 @@
13531353
<seeElement selector="{{SlideOnFrontend.messageContent('2', PageBuilderSlideItemContent_Slide2.value)}}" stepKey="seeSlide2ContentCMSPageStorefront3"/>
13541354
<actionGroup ref="validateContentTypeHeightEqualToMinHeightPlusPaddingAndBorder" stepKey="validateHeightSlide2CMSPageStorefront">
13551355
<argument name="content" value="{{SlideOnFrontend.wrapperCSS}}"/>
1356-
<argument name="height" value="{{PageBuilderMinHeightProperty_500px.intValue}}"/>
1356+
<argument name="minHeight" value="{{PageBuilderMinHeightProperty_500px.intValue}}"/>
13571357
<argument name="index" value="2"/>
13581358
</actionGroup>
13591359
</test>
@@ -1474,7 +1474,7 @@
14741474
<seeElement selector="{{SlideOnBackend.posterMinimumHeight('1', PageBuilderMinHeightProperty_500px.value)}}" stepKey="seeMinimumHeightCMSBlockStage"/>
14751475
<actionGroup ref="validateContentTypeHeightEqualToMinHeightPlusPaddingAndBorder" stepKey="validateHeightCMSBlockStage">
14761476
<argument name="content" value="{{SlideOnBackend.wrapperCSS}}"/>
1477-
<argument name="height" value="{{PageBuilderMinHeightProperty_500px.intValue}}"/>
1477+
<argument name="minHeight" value="{{PageBuilderMinHeightProperty_500px.intValue}}"/>
14781478
</actionGroup>
14791479
<actionGroup ref="validateBackgroundAttributesWithNoImageForSlide" stepKey="validateBackgroundAttributesCMSBlockStage">
14801480
<argument name="section" value="SlideOnBackend"/>
@@ -1536,7 +1536,7 @@
15361536
<seeElement selector="{{SlideOnFrontend.minimumHeight('1', PageBuilderMinHeightProperty_500px.value)}}" stepKey="seeMinimumHeightCMSPageStage"/>
15371537
<actionGroup ref="validateContentTypeHeightEqualToMinHeightPlusPaddingAndBorder" stepKey="validateHeightCMSPageStage">
15381538
<argument name="content" value="{{SlideOnFrontend.wrapperCSS}}"/>
1539-
<argument name="height" value="{{PageBuilderMinHeightProperty_500px.intValue}}"/>
1539+
<argument name="minHeight" value="{{PageBuilderMinHeightProperty_500px.intValue}}"/>
15401540
</actionGroup>
15411541
<actionGroup ref="validateBackgroundAttributesWithNoImageForSlide" stepKey="validateBackgroundAttributesCMSPageStage">
15421542
<argument name="section" value="SlideOnFrontend"/>
@@ -1580,7 +1580,7 @@
15801580
<seeElement selector="{{SlideOnFrontend.minimumHeight('1', PageBuilderMinHeightProperty_500px.value)}}" stepKey="seeMinimumHeightCMSPageStorefront"/>
15811581
<actionGroup ref="validateContentTypeHeightEqualToMinHeightPlusPaddingAndBorder" stepKey="validateHeightCMSPageStorefront">
15821582
<argument name="content" value="{{SlideOnFrontend.wrapperCSS}}"/>
1583-
<argument name="height" value="{{PageBuilderMinHeightProperty_500px.intValue}}"/>
1583+
<argument name="minHeight" value="{{PageBuilderMinHeightProperty_500px.intValue}}"/>
15841584
</actionGroup>
15851585
<actionGroup ref="validateBackgroundAttributesWithNoImageForSlide" stepKey="validateBackgroundAttributesCMSPageStorefront">
15861586
<argument name="section" value="SlideOnFrontend"/>
@@ -1631,7 +1631,7 @@
16311631
</actionGroup>
16321632
<actionGroup ref="validateContentTypeHeightEqualToMinHeightPlusPaddingAndBorder" stepKey="validateHeightCMSPageStorefrontMobile">
16331633
<argument name="content" value="{{SlideOnFrontend.wrapperCSS}}"/>
1634-
<argument name="height" value="{{PageBuilderMinHeightProperty_500px.intValue}}"/>
1634+
<argument name="minHeight" value="{{PageBuilderMinHeightProperty_500px.intValue}}"/>
16351635
</actionGroup>
16361636
<actionGroup ref="validateBackgroundImageContainer" stepKey="validateBackgroundImageCMSPageStorefrontMobile">
16371637
<argument name="section" value="SlideOnFrontend"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSliderCommonTests.xml

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -596,24 +596,27 @@
596596
<actionGroup ref="saveEditPanelSettings" after="enterMinHeightPropertySlideItem" stepKey="saveEditPanelSettings2"/>
597597
<actionGroup ref="validateContentTypeHeightEqualToMinHeightPlusPaddingAndBorder" stepKey="validateContentTypeHeightBeforeSave">
598598
<argument name="content" value="{{SliderOnStage.containerCSS}}"/>
599-
<argument name="height" value="{{PageBuilderMinHeightProperty_300px.intValue}}"/>
600-
<argument name="border" value="PageBuilderAdvancedBorderWidthProperty10"/>
601-
<argument name="padding" value="PageBuilderPaddingProperty10"/>
599+
<argument name="minHeight" value="{{PageBuilderMinHeightProperty_300px.intValue}}"/>
600+
<argument name="borderWidth" value="{{PageBuilderAdvancedBorderWidthProperty10.value}}"/>
601+
<argument name="paddingTop" value="{{PageBuilderPaddingProperty10.paddingTop}}"/>
602+
<argument name="paddingBottom" value="{{PageBuilderPaddingProperty10.paddingBottom}}"/>
602603
</actionGroup>
603604
<actionGroup ref="validateContentTypeHeightEqualToMinHeightPlusPaddingAndBorder" stepKey="validateContentTypeHeightAfterSave">
604605
<argument name="content" value="{{SliderOnStage.containerCSS}}"/>
605-
<argument name="height" value="{{PageBuilderMinHeightProperty_300px.intValue}}"/>
606-
<argument name="border" value="PageBuilderAdvancedBorderWidthProperty10"/>
607-
<argument name="padding" value="PageBuilderPaddingProperty10"/>
606+
<argument name="minHeight" value="{{PageBuilderMinHeightProperty_300px.intValue}}"/>
607+
<argument name="borderWidth" value="{{PageBuilderAdvancedBorderWidthProperty10.value}}"/>
608+
<argument name="paddingTop" value="{{PageBuilderPaddingProperty10.paddingTop}}"/>
609+
<argument name="paddingBottom" value="{{PageBuilderPaddingProperty10.paddingBottom}}"/>
608610
</actionGroup>
609611
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
610612
<argument name="contentType" value="PageBuilderSliderContentType"/>
611613
</actionGroup>
612614
<actionGroup ref="validateContentTypeHeightEqualToMinHeightPlusPaddingAndBorder" stepKey="validateContentTypeHeightStorefront">
613615
<argument name="content" value="{{SliderOnFrontend.all}}"/>
614-
<argument name="height" value="{{PageBuilderMinHeightProperty_300px.intValue}}"/>
615-
<argument name="border" value="PageBuilderAdvancedBorderWidthProperty10"/>
616-
<argument name="padding" value="PageBuilderPaddingProperty10"/>
616+
<argument name="minHeight" value="{{PageBuilderMinHeightProperty_300px.intValue}}"/>
617+
<argument name="borderWidth" value="{{PageBuilderAdvancedBorderWidthProperty10.value}}"/>
618+
<argument name="paddingTop" value="{{PageBuilderPaddingProperty10.paddingTop}}"/>
619+
<argument name="paddingBottom" value="{{PageBuilderPaddingProperty10.paddingBottom}}"/>
617620
</actionGroup>
618621
</test>
619622
<test name="SliderWithNoDotsEqualToMinHeight" extends="RowWithBordersAndPaddingEqualToMinHeight">
@@ -666,18 +669,18 @@
666669
<actionGroup ref="saveEditPanelSettings" after="enterBackgroundColor" stepKey="saveEditPanelSettings2"/>
667670
<actionGroup ref="validateContentTypeHeightEqualToMinHeightPlusPaddingAndBorder" stepKey="validateContentTypeHeightBeforeSave">
668671
<argument name="content" value="{{SliderOnStage.containerCSS}}"/>
669-
<argument name="height" value="{{PageBuilderMinHeightProperty_300px.intValue}}"/>
672+
<argument name="minHeight" value="{{PageBuilderMinHeightProperty_300px.intValue}}"/>
670673
</actionGroup>
671674
<actionGroup ref="validateContentTypeHeightEqualToMinHeightPlusPaddingAndBorder" stepKey="validateContentTypeHeightAfterSave">
672675
<argument name="content" value="{{SliderOnStage.containerCSS}}"/>
673-
<argument name="height" value="{{PageBuilderMinHeightProperty_300px.intValue}}"/>
676+
<argument name="minHeight" value="{{PageBuilderMinHeightProperty_300px.intValue}}"/>
674677
</actionGroup>
675678
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
676679
<argument name="contentType" value="PageBuilderSliderContentType"/>
677680
</actionGroup>
678681
<actionGroup ref="validateContentTypeHeightEqualToMinHeightPlusPaddingAndBorder" stepKey="validateContentTypeHeightStorefront">
679682
<argument name="content" value="{{SliderOnFrontend.all}}"/>
680-
<argument name="height" value="{{PageBuilderMinHeightProperty_300px.intValue}}"/>
683+
<argument name="minHeight" value="{{PageBuilderMinHeightProperty_300px.intValue}}"/>
681684
</actionGroup>
682685
</test>
683686
<test name="SliderMoveSlider">

0 commit comments

Comments
 (0)