Skip to content

Commit 34d5c3d

Browse files
MC-3695: Remove Newsletter
- remove newsletter template
1 parent a11f320 commit 34d5c3d

File tree

3 files changed

+42
-56
lines changed

3 files changed

+42
-56
lines changed

app/code/Magento/PageBuilder/Setup/DataConverter/Renderer/Newsletter.php

Lines changed: 41 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -44,12 +44,26 @@ public function render(array $itemData, array $additionalData = []) : string
4444
}
4545
$eavData = $this->eavAttributeLoader->load($itemData['entityId']);
4646

47-
$newsletterClasses = $eavData['css_classes'] ?? '';
48-
$newsletterButtonText = $eavData['button_text'] ?? '';
49-
$newsletterLabel = $eavData['label'] ?? '';
50-
$newsletterTitle = $eavData['title'] ?? '';
51-
$newsletterPlaceHolder = $eavData['placeholder'] ?? '';
47+
$rootElementHtml = '<div data-element="main" data-role="html" data-appearance="default">';
48+
$rootElementHtml .= $this->getNewsletterHtml($itemData, $eavData) . '</div>';
49+
50+
return $rootElementHtml;
51+
}
5252

53+
/**
54+
* get the html for the newsletter
55+
*
56+
* @param array $itemData
57+
* @param array $eavData
58+
* @return string
59+
*/
60+
private function getNewsletterHtml(array $itemData, array $eavData): string
61+
{
62+
$newsletterButtonText = $eavData['button_text'] ?? __('Subscribe');
63+
$newsletterLabel = $eavData['label'] ?? __('Sign Up for Our Newsletter:');
64+
$newsletterTitle = $eavData['title'] ?? __('Newsletter');
65+
$newsletterPlaceHolder = $eavData['placeholder'] ?? __('Enter your email address');
66+
$newsletterClasses = $eavData['css_classes'] ?? '';
5367
$newsletterStyles = '';
5468
if (isset($itemData['formData'])) {
5569
$justifyContent = '';
@@ -69,18 +83,29 @@ public function render(array $itemData, array $additionalData = []) : string
6983
}
7084
}
7185

72-
$newsletterHtml = "{{block class=\"Magento\Newsletter\Block\Subscribe\" " .
73-
"template=\"Magento_PageBuilder::content_type/newsletter.phtml\" " .
74-
"placeholder=\"$newsletterPlaceHolder\" " .
75-
"classes=\"$newsletterClasses\" " .
76-
"styles=\"$newsletterStyles\" " .
77-
"button_text=\"$newsletterButtonText\" " .
78-
"label_text=\"$newsletterLabel\" " .
79-
"title=\"$newsletterTitle\"}}";
86+
$newsletterHtml = '<div class="' . $newsletterClasses . '" style="' . $newsletterStyles . '">' .
87+
'<div class="block newsletter"><div class="title"><strong>' . $newsletterTitle . '</strong></div>' .
88+
'<div class="content">' .
89+
'<form class="form subscribe" novalidate method="post" ' .
90+
'action="{{store direct_url=\'newsletter/subscriber/new\' _secure=1}}" ' .
91+
'data-mage-init=\'{"validation": {"errorClass": "mage-error"}}\'>' .
92+
'<div class="field newsletter">' .
93+
'<label class="label" for="newsletter-' . $itemData['entityId'] . '">' .
94+
'<span>' . $newsletterLabel . '</span>'.
95+
'</label>' .
96+
'<div class="control">' .
97+
'<input name="email" type="email" id="newsletter-' . $itemData['entityId'] . '" '.
98+
'placeholder="' . $newsletterPlaceHolder . '" ' .
99+
'data-mage-init=\'{"mage/trim-input":{}}\' ' .
100+
'data-validate="{required:true, \'validate-email\':true}"/>' .
101+
'</div></div>' .
102+
'<div class="actions">' .
103+
'<button class="action subscribe primary" title="' . $newsletterButtonText . '" type="submit">' .
104+
'<span>' . $newsletterButtonText . '</span>' .
105+
'</button>' .
106+
'</div></form></div></div></div>';
80107

81-
$rootElementHtml = '<div data-element="main" data-role="html" data-appearance="default">';
82-
$rootElementHtml .= $newsletterHtml . '</div>';
83108

84-
return $rootElementHtml;
109+
return $newsletterHtml;
85110
}
86111
}

app/code/Magento/PageBuilder/view/frontend/templates/content_type/newsletter.phtml

Lines changed: 0 additions & 39 deletions
This file was deleted.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<div data-element="main" data-role="row" data-appearance="contained"><div data-element="inner"><div data-element="main" data-role="html" data-appearance="default">{{block class="Magento\Newsletter\Block\Subscribe" template="Magento_PageBuilder::content_type/newsletter.phtml" placeholder="Placeholder" classes="newsletter-one newsletter-two" styles="display: flex; margin: 5px 5px 5px 5px; padding: 1px 1px 1px 1px; justify-content: center;" button_text="Button Text" label_text="Label" title="Title"}}</div></div></div>
1+
<div data-element="main" data-role="row" data-appearance="contained"><div data-element="inner"><div data-element="main" data-role="html" data-appearance="default"><div class="newsletter-one newsletter-two" style="display: flex; margin: 5px 5px 5px 5px; padding: 1px 1px 1px 1px; justify-content: center;"><div class="block newsletter"><div class="title"><strong>Title</strong></div><div class="content"><form class="form subscribe" novalidate method="post" action="{{store direct_url='newsletter/subscriber/new' _secure=1}}" data-mage-init='{"validation": {"errorClass": "mage-error"}}'><div class="field newsletter"><label class="label" for="newsletter-1"><span>Label</span></label><div class="control"><input name="email" type="email" id="newsletter-1" placeholder="Placeholder" data-mage-init='{"mage/trim-input":{}}' data-validate="{required:true, 'validate-email':true}"/></div></div><div class="actions"><button class="action subscribe primary" title="Button Text" type="submit"><span>Button Text</span></button></div></form></div></div></div></div></div></div>

0 commit comments

Comments
 (0)