Skip to content

Commit 49ab907

Browse files
committed
MC-3934: Slide/Banner Overlay & Button Do Not Show On Storefront When Set To On Hover
Address feedback from CR
1 parent e378184 commit 49ab907

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerPosterAppearanceTest.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -812,8 +812,10 @@
812812
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterBannerOverlayTransparency">
813813
<argument name="property" value="PageBuilderBannerOverlayTransparencyProperty"/>
814814
</actionGroup>
815-
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterBannerLinkUrl">
815+
<actionGroup ref="fillSlideOutPanelLinkUrlField" stepKey="enterBannerLinkUrl">
816816
<argument name="property" value="PageBuilderBannerLinkUrlPropertyValidate"/>
817+
<argument name="selection" value="{{ExternalLink.url}}"/>
818+
<argument name="newTab" value="PageBuilderBannerNewTabDefaultProperty"/>
817819
</actionGroup>
818820
<!-- Add Link To WYSIWYG -->
819821
<comment userInput="Add Link To WYSIWYG" stepKey="commentAddLink"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearancePosterTests.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -603,7 +603,6 @@
603603
<seeElement selector="{{SlideOnFrontend.button('1')}}" stepKey="seeButtonOnHoverStorefront"/>
604604
<seeElement selector="{{SlideOnFrontend.overlayColorAndTransparency('1', PageBuilderSlideItemOverlayColor_HexWhite.rgb, PageBuilderSlideItemOverlayTransparency_70.decimal)}}" stepKey="seeOverlayOnHoverStorefront"/>
605605
<moveMouseOver selector="{{SlideOnFrontend.base('1')}}" x="-1" y="0" stepKey="moveMouseAwayFromSlide"/>
606-
607606
<!-- Click slide anchor -->
608607
<comment userInput="Click slide anchor" stepKey="clickSlideAnchorStorefront" />
609608
<click selector="{{SlideOnFrontend.linkUrl('1', PageBuilderSlideItemLinkURL_External.value)}}" stepKey="clickLinkUrlStorefront"/>
@@ -618,7 +617,6 @@
618617
<click selector="{{SlideOnFrontend.wysiwygLinkUrl('1', ExternalLink.googleUrl)}}" stepKey="clickWysiwygLinkUrlStorefront"/>
619618
<wait time="3" stepKey="waitArbitraryTimeForPotentialNavigationToOccurStorefront2" />
620619
<seeCurrentUrlEquals url="{{ExternalLink.googleUrl}}" stepKey="seeThatUrlIsChangedToWysiwygLinkUrlStorefront" />
621-
622620
<!-- Validate Storefront Mobile -->
623621
<comment userInput="Validate Storefront Mobile" stepKey="commentValidateStorefrontMobile"/>
624622
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront3">

0 commit comments

Comments
 (0)