Skip to content

Commit 49c34f0

Browse files
MAGETWO-91981: Create New Vertical Appearance from Prototype
- fix DataConverter appearance for buttons and master format documentation
1 parent f3e4761 commit 49c34f0

File tree

6 files changed

+9
-7
lines changed

6 files changed

+9
-7
lines changed

app/code/Magento/PageBuilder/Setup/DataConverter/Renderer/Buttons.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public function render(array $itemData, array $additionalData = [])
4444

4545
$rootElementAttributes = [
4646
'data-role' => 'buttons',
47-
'data-appearance' => 'default',
47+
'data-appearance' => 'inline',
4848
'class' => $eavData['css_classes'] ?? ''
4949
];
5050

app/code/Magento/PageBuilder/docs/master-format.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -252,12 +252,12 @@ Inline styles
252252
## Buttons
253253

254254
```
255-
<div data-role="buttons" data-appearance="default" style="..."></div>
255+
<div data-role="buttons" data-appearance="inline" style="..."></div>
256256
```
257257

258258
Attributes
259259
1. data-role [buttons]
260-
2. data-appearance [default]
260+
2. data-appearance [inline, stacked]
261261
3. class
262262

263263
Inline styles
@@ -268,6 +268,8 @@ Inline styles
268268
5. border-radius
269269
6. margin
270270
7. padding
271+
8. display (only on stacked appearance)
272+
9. flex-direction (only on stacked appearance)
271273

272274
## Button item
273275

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<div data-role="row" data-appearance="default"><div data-role="buttons" data-appearance="default" class="one two" style="text-align: left; margin: 2px 3px 4px 1px; padding: 6px 7px 8px 5px;"><div data-role="button-item" data-appearance="default" style="display: inline-block;" class="three four"><a href="http://domain.com/" style="text-align: right; margin: 0px 2px 0px 1px; padding: 3px 0px 4px 0px;" class="pagebuilder-button-primary"><span>Domain.com</span></a></div></div></div>
1+
<div data-role="row" data-appearance="default"><div data-role="buttons" data-appearance="inline" class="one two" style="text-align: left; margin: 2px 3px 4px 1px; padding: 6px 7px 8px 5px;"><div data-role="button-item" data-appearance="default" style="display: inline-block;" class="three four"><a href="http://domain.com/" style="text-align: right; margin: 0px 2px 0px 1px; padding: 3px 0px 4px 0px;" class="pagebuilder-button-primary"><span>Domain.com</span></a></div></div></div>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<div data-role="row" data-appearance="default"><div data-role="buttons" data-appearance="default" style="padding: 10px 10px 0px;"></div></div>
1+
<div data-role="row" data-appearance="default"><div data-role="buttons" data-appearance="inline" style="padding: 10px 10px 0px;"></div></div>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<div data-role="row" data-appearance="default"><div data-role="buttons" data-appearance="default" style="text-align: left; margin: 2px 3px 4px 1px; padding: 6px 7px 8px 5px;"><div data-role="button-item" data-appearance="default" style="display: inline-block;"><a href="http://domain.com/" style="text-align: right; margin: 0px 2px 0px 1px; padding: 3px 0px 4px 0px;" class="pagebuilder-button-primary"><span></span></a></div></div></div>
1+
<div data-role="row" data-appearance="default"><div data-role="buttons" data-appearance="inline" style="text-align: left; margin: 2px 3px 4px 1px; padding: 6px 7px 8px 5px;"><div data-role="button-item" data-appearance="default" style="display: inline-block;"><a href="http://domain.com/" style="text-align: right; margin: 0px 2px 0px 1px; padding: 3px 0px 4px 0px;" class="pagebuilder-button-primary"><span></span></a></div></div></div>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<div data-role="row" data-appearance="default"><div data-role="buttons" data-appearance="default" style="text-align: left; margin: 2px 3px 4px 1px; padding: 6px 7px 8px 5px;"><div data-role="button-item" data-appearance="default" style="display: inline-block;"><a href="" style="text-align: right; margin: 0px 2px 0px 1px; padding: 3px 0px 4px 0px;" class="pagebuilder-button-primary"><span>Domain.com</span></a></div></div></div>
1+
<div data-role="row" data-appearance="default"><div data-role="buttons" data-appearance="inline" style="text-align: left; margin: 2px 3px 4px 1px; padding: 6px 7px 8px 5px;"><div data-role="button-item" data-appearance="default" style="display: inline-block;"><a href="" style="text-align: right; margin: 0px 2px 0px 1px; padding: 3px 0px 4px 0px;" class="pagebuilder-button-primary"><span>Domain.com</span></a></div></div></div>

0 commit comments

Comments
 (0)